West Midlands | 25 Sep ITP | Iswat Bello | Sprint 3 | Build alarm clock app #865
+77
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red time-formatting logic into an updateDisplay helper function
…meRemaining title background to blue at end and reset to default at start
Iswanna
added
🏕 Priority Mandatory
jaymes15
added
Review in progress
jaymes15
reviewed
Nov 22, 2025
| let intervalId; | ||
|
|
||
| // Helper function to format total seconds and update the UI | ||
| function updateDisplay(totalSeconds) { |
jaymes15
reviewed
Nov 22, 2025
| let totalSeconds = Number(inputElement.value); //this converts the input from string to number | ||
|
|
||
| // Validate input | ||
| if (totalSeconds <= 0 || isNaN(totalSeconds)) { |
jaymes15
reviewed
Nov 22, 2025
| // the code you write here will run every one second or 1000 milliseconds | ||
| totalSeconds = totalSeconds - 1; | ||
| if (totalSeconds <= 0) { | ||
| clearInterval(intervalId); |
jaymes15
suggested changes
Nov 22, 2025
Sprint-3/alarmclock/alarmclock.js
Outdated
| clearInterval(intervalId); | ||
| playAlarm(); | ||
| document.getElementById("timeRemaining").textContent = | ||
| "Time Remaining: 00:00"; |
jaymes15
added
Reviewed
Iswanna
added
Needs Review
Author
|
Hi @jaymes15 . I have updated my code with the changes. Please kindly review my PR. Thank you. |
jaymes15
approved these changes
Nov 23, 2025
jaymes15
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In this pull request, I completed the alarm clock project by implementing the setAlarm functionality with input validation, a live countdown in mm:ss format, and alarm sound at 00:00. I added a helper function to update the display, clear the input, and change the background color when the countdown finishes.
Questions
Hi. Please could you review my PR? I’d really appreciate your feedback.