London | 25-ITP-Sep| Sophia Mohamed | Sprint 2 | Sprint 2 Coursework #861

saff-coder · 2025-11-19T11:56:33Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have implemented the required functions, and run the required tests

Questions

No questions, thank you

cjyuan

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Groups/blob/general-review-feedback/Sprint-2/feedback.md

Doing so can help reviewers speed up the review process. Thanks.

Now the function can decode a URL-encoded string in JavaScript

Now the function can test if the array is empty

saff-coder · 2025-11-22T13:04:35Z

I have updated all the codes

cjyuan · 2025-11-22T23:00:47Z

Sprint-2/debug/recipe.js

+${recipe.ingredients[0]}
+${recipe.ingredients[1]}
+${recipe.ingredients[2]}
+${recipe.ingredients[3]}`);


Can you figure out an approach that could work for any number of ingredients?

cjyuan · 2025-11-22T23:02:42Z

Sprint-2/implement/contains.test.js

+test("contains on invalid parameters returns false", () => {
+  expect(contains([], "a")).toBe(false);


Which of the parameters on line 48 is "invalid"?

You’re right — in that test, neither parameter is actually invalid.
[ ] is still an object in JavaScript, and "a" is a valid key, so the test title didn’t match the behaviour.
I’ve now updated the test to use invalid parameters (such as strings, numbers, null, and undefined)

cjyuan · 2025-11-22T23:03:50Z

Sprint-2/implement/lookup.js

+  for (const pair of pairs) {
+    const country = pair[0];// first element is country code
+    const currency = pair[1];// second element is currency code


Could consider using array destructuring syntax to simplify the code on lines 4-6.

Thanks for the feedback!
I’ve updated the loop to use array destructuring so the code is cleaner and easier to read.

cjyuan · 2025-11-22T23:07:51Z

Sprint-2/implement/querystring.js

+function parseQueryString(query) {
+  const result = {};
+  if (!query) return result;
+
+  const pairs = query.split("&");
+
+  for (let pair of pairs) {
+    const index = pair.indexOf("=");
+
+    // Key has no "=" → value is empty string
+    if (index === -1) {
+      const key = decodeURIComponent(pair);
+      result[key] = "";
+      continue;
+    }
+
+    // Key is before "=", value is EVERYTHING after "="
+    const rawKey = pair.slice(0, index);
+    const rawValue = pair.slice(index + 1);

-  for (const pair of keyValuePairs) {
-    const [key, value] = pair.split("=");
-    queryParams[key] = value;
+    const key = decodeURIComponent(rawKey);
+    const value = decodeURIComponent(rawValue);
+
+    result[key] = value;
  }

-  return queryParams;
+  return result;
 }


This work well.
Could also consider explore and exploit a built-in function to parse query string.

Thank you for the suggestion!
I have now explored the built-in URLSearchParams

cjyuan · 2025-11-22T23:10:29Z

Sprint-2/implement/tally.test.js

+test("counts how many times each item appears", () => {
+  expect(tally(["a", "b", "a", "c", "b", "a"])).toEqual({
+    a: 3,
+    b: 2,
+    c: 1,
+  });
+});


Does tally(["constructor", "constructor"]) return what you expect?

thank you!
tally(["constructor", "constructor"]) didn’t work properly because I was using a normal {} object, so "constructor" clashed with the built-in constructor property.
I used Object.create(null) so "constructor" behaves like normal keys and doesn’t clash with JavaScript’s internal properties.

cjyuan

Excellent work! You clearly know what the code does.

And thanks for the detailed responses.

saff-coder added 8 commits November 17, 2025 12:07

corrected te Address function

3999300

fixed the error in the code

8163ad3

corrected the function in recipe

65b3e2d

Update the function and run the tests

53492c8

implement a function and run the tests

b8ae2b9

Implementation and tests done on Querystring

6cf8277

implementing the function tally and all the tests are done

0d76de5

the function was updated and the error explained

c64fdeb

saff-coder added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 19, 2025

cjyuan reviewed Nov 21, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 21, 2025

saff-coder added 3 commits November 22, 2025 11:53

updated the function and the test

2b867f0

updated the function and the test in querysting.js

9411e67

Now the function can decode a URL-encoded string in JavaScript

updated the code

3be182c

Now the function can test if the array is empty

saff-coder added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 22, 2025

cjyuan reviewed Nov 22, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 22, 2025

saff-coder added 5 commits November 22, 2025 23:44

updated the recipe function

ee8befa

updated the contain.test

96fc157

updated the lookup function

604d8ff

Updated both querystring and querystring.test

0e9c2c9

updated the test and the code in tally function

e3eee4c

saff-coder added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 23, 2025

cjyuan reviewed Nov 23, 2025

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 23, 2025

cjyuan added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Nov 23, 2025

		test("contains on invalid parameters returns false", () => {
		expect(contains([], "a")).toBe(false);

Uh oh!

London | 25-ITP-Sep| Sophia Mohamed | Sprint 2 | Sprint 2 Coursework #861

Are you sure you want to change the base?

London | 25-ITP-Sep| Sophia Mohamed | Sprint 2 | Sprint 2 Coursework #861

Conversation

saff-coder commented Nov 19, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

saff-coder commented Nov 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants