Birmingham | ITP-Sep-25 | Ahmad Ehsas | sprint 2 | Data groups #805

ahmadehsas · 2025-10-28T12:50:52Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have completed all the required tasks.

Questions

…l the tets.

… tests cases.

…rray and passed the tests of given arrays.

…en tests.

…seNumber property.

…by join(\n) method.

github-actions · 2025-10-28T12:51:04Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:51:15Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:51:18Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:51:19Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:51:29Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:51:36Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan · 2025-11-11T21:44:58Z

Title is not in the right format.
PR branch is not clean.

Can you address these issues?

github-actions · 2025-11-11T21:45:21Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-11T21:45:24Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan · 2025-11-20T08:09:23Z

You can view all the changed files of this PR branch on https://github.com/CodeYourFuture/Module-Data-Groups/pull/805/files

You copied the Sprint-1 folder into the wrong folder; you haven't yet replaced the modified Sprint-1 folder. Can you make this branch clean?

ahmadehsas · 2025-11-20T14:45:19Z

As I had this issue in my previous module, 'Structuring and testing data' then i followed your instructions:
Download your [main branch] as a ZIP file.

In VSCode, switch to this branch (Sprint-2).

Copy these files from the ZIP file to this branch (make sure they are copied to the right folder)
Push the change to GitHub.

I did this, and now I am a little bit confused, and I need your clarification in more detail.

cjyuan · 2025-11-20T16:28:24Z

You did everything right, except copying the "Sprint-1" folder to the right folder.

I think you can easily fix the issue by

Deleting "Sprint-1" folder in the top-level folder in your branch
Move "Sprint-2/Sprint-1" to the top-level folder in your branch

If you need interactive assistance, I am available today or tomorrow evening. You can DM me on Slack, "CJ Yuan".

cjyuan · 2025-11-21T17:03:16Z

Sprint-2/debug/author.js

+// This means that we need to check if the property belongs to the object using hasownproperty whenever we loop through an object with the `for ... in` loop.
+
+for (const key in author) {
+  if (author.hasOwnProperty(key)) {


Why introduce the if-statement on line 21? Can you justify its need?

When I tested my code without the 'if ... statement', it worked, but the if ... statement is neccessary if there might be properties inherited from the prototype chain.
So the 'if' check doesn't change the output.

You can output the value of key within the loop to see what values you get

You can also use AI to help you clarify some concept

cjyuan · 2025-11-21T17:07:39Z

Sprint-2/implement/contains.test.js

+test("contains on an array returns false", () => {
+  expect(contains([1, 2, 3], 4)).toBe(false);
+});
+
+test("contains on an array of length returns true", () => {
+  expect(contains([1, 2, 3, 4], "length")).toBe(true);
+}); // the test returns true because 'length' is a property of the array object
+
+test("contains given on array as input return false", () => {
+  expect(contains([1, 2, 3], "a")).toBe(false);
+});


Do these function calls return what you expect?

contains([1, 2, 3], "0"); contains(null, "a"); contains(undefined, "a"); contains(1234, "a");

My function checks for its own property on an object. For the first input `contains([1, 2, 3], "0"); return true because arrays are objects and "0" is a property key.
Inputs like 'null', 'undefined', and '123' will cause errors because they are not objects.

In that case you may want to update the test descriptions on lines 44 and 52.

cjyuan · 2025-11-21T17:15:29Z

Sprint-2/implement/querystring.js

  const keyValuePairs = queryString.split("&");

  for (const pair of keyValuePairs) {
-    const [key, value] = pair.split("=");
+    const [key, value] = pair.split(/=(.+)/); // We use regex to split only at first.
    queryParams[key] = value;
  }


Does this function call return what you expect?

parseQuerySring("A=");

In real query string, both key and value are percent-encoded or URL encoded.
For example,

tags%5B%5D=hello%20world -> key is tags[], value is hello world

Can your function handle URL-encoded query string?

Suggestion: Look up "How to decode a URL-encoded string in JavaScript".

cjyuan · 2025-11-21T17:16:14Z

Sprint-2/implement/tally.js

+    throw new Error("Input must be an array");
+    // check if the input ia an array. if not, throw an error.
+  }
+  const tally = {};


Does the following function call returns the value you expect?

tally(["toString", "toString"]);

Suggestion: Look up an approach to create an empty object with no inherited properties.

cjyuan · 2025-11-21T17:19:08Z

Sprint-2/interpret/invert.js

+// The current return value is {1: "a"}

 // b) What is the current return value when invert is called with { a: 1, b: 2 }
+// The current return value is {1: "a", 2: "b"}


The "current return value" refers to the value returned by the original (unmodified) function.

With the original function, the objects you described on line 23 and 26 are not the objects returned by the function.

Can you find out the actual object returned by the original function?

cjyuan · 2025-11-23T11:32:43Z

Sprint-2/debug/author.js

 for (const key in author) {
-  if (author.hasOwnProperty(key)) {
+ // if (author.hasOwnProperty(key)) {
    console.log(`${key}: ${author[key]}`);
  }
-}
+//}


Leaving commented out unused code can make code review difficult. Can you keep the the code clean by removing all unnecessary code?

cjyuan · 2025-11-23T11:37:34Z

Sprint-2/implement/contains.test.js

 test("contains on an array of length returns true", () => {
-  expect(contains([1, 2, 3, 4], "length")).toBe(true);
+  // expect(contains([1, 2, 3, 4], "length")).toBe(true);
+  expect(contains(null, "a", "length")).toBe(true);
 }); // the test returns true because 'length' is a property of the array object

 test("contains given on array as input return false", () => {
-  expect(contains([1, 2, 3], "a")).toBe(false);
+  // expect(contains([1, 2, 3], "a")).toBe(false);
+  expect(contains(1234, "a")).toBe(false);
 });


Do you expect the function to accept an array as its first parameter or not? These two test descriptions are contradicting each other.

cjyuan · 2025-11-23T11:49:17Z

Sprint-2/interpret/invert.js

+// The current return value is {'1': 'a'}

 // b) What is the current return value when invert is called with { a: 1, b: 2 }
-// The current return value is {1: "a", 2: "b"}
+// The current return value is {'1': 'a', '2': 'b'}


These are still not the objects returned by the original (unmodified) function.

ahmadehsas added 16 commits July 28, 2025 15:16

Fixed the implementaton of the function CalculateMedian and passed al…

96e54cd

…l the tets.

Implemented the deduplicate function with given arrays and passed the…

d577680

… tests cases.

Implemented the function findMax and passed the tests for given arrays.

3ecbe9f

Implemented the function sum that sums the numerical elements of an a…

0467d03

…rray and passed the tests of given arrays.

Refactored the implementation of Includes function and passed the giv…

a9a5914

…en tests.

Fixed the code address object and used dot notation to access the hou…

d5ca4ab

…seNumber property.

Explained and fixed the problem in the mention code.

ce7733e

Fixed the mention code and printed out each ingredient in a new line …

73e8544

…by join(\n) method.

Implemented the function Contain, and passed tests for this function.

f512318

Implemented the createLookup function and passed the test.

22c4094

Fixed the implementation for this test and wrote tests.

1231d9c

Implemented the function called tally and passed tests.

aa42568

Fixed the implementation of invert function and wrote tests.

ef820ad

passed the test for contains of an array of length returns true.

898abfc

Fixed the code in one line with prettier-ignore.

2bc209b

fixed the test for given an array as input return false.

d0788b8

ahmadehsas added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 28, 2025

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 11, 2025

Restore Sprint-1 folder to match main branch.

9940e55

ahmadehsas added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 12, 2025

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 20, 2025

ahmadehsas added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 20, 2025

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 20, 2025

ahmadehsas added 2 commits November 21, 2025 15:05

Fixed Sprint-1.

ae98aa1

Moved prep folder from this branch.

268774e

cjyuan reviewed Nov 21, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 21, 2025

ahmadehsas added 4 commits November 21, 2025 18:28

checked if the code is working without if... statement.

9c2f2f8

changed the regax + to * to work for a zero characters.

1f7a23d

created an object with no prototype.

fa7c649

modified the answers of question 'a' and 'b'.

e165bfe

ahmadehsas added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 23, 2025

cjyuan reviewed Nov 23, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 23, 2025

Uh oh!

Birmingham | ITP-Sep-25 | Ahmad Ehsas | sprint 2 | Data groups #805

Are you sure you want to change the base?

Birmingham | ITP-Sep-25 | Ahmad Ehsas | sprint 2 | Data groups #805

Conversation

ahmadehsas commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Questions

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

cjyuan commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

cjyuan commented Nov 20, 2025

Uh oh!

ahmadehsas commented Nov 20, 2025

Uh oh!

cjyuan commented Nov 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ahmadehsas commented Oct 28, 2025 •

edited

Loading