[BUGFIX] csv export null fk #225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BBooijLiewes
requested changes
Mar 5, 2025
| # Assume that we have a mapping now | ||
| fk_ids = data[head_key] | ||
|
|
||
| # If foreign key is null don't try to fetch the data and stop |
Contributor
There was a problem hiding this comment.
Can you also add this to the second bullet of the comment of the else statement?
https://github.com/CodeYellowBV/django-binder/pull/225/files#diff-4128d9ae74d08c29bcc4b2d5e871778087ec91853f76d1804283f78db3a9c97fR275-R278
macmac4
force-pushed
the
bugfix-csv-export-empty-fk
branch
from
7fa8571 to
633d770
Compare
macmac4
force-pushed
the
field-filter-chain-qualifiers
branch
from
65b5fd7 to
66e7153
Compare
macmac4
force-pushed
the
bugfix-csv-export-empty-fk
branch
from
633d770 to
e3335e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to do a csv export of an object with null fk like:
"order.trailer.id"
It was crashing when trailer was a null object as it tried to fetch id data from null object. This has been fixed. Test is added and changelog updated.