Use the django default user method get_username() in the history for #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obaining the username of the user. This uses the USERNAME_FIELD attribute on the abstract user model class in order to obtain which user attribute to use as username. For the default user model it defaults back to username, which is a valid attribute there. See https://docs.djangoproject.com/en/3.2/topics/auth/customizing/#django.contrib.auth.models.AbstractBaseUser.get_username for more info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
obtaining the username of the user using the
get_usernamemethod.This uses the
USERNAME_FIELDattribute on the abstract user model classin order to obtain which user attribute to use as username. For the
default user model it defaults back to username, which is a valid
attribute there. See:
https://docs.djangoproject.com/en/3.2/topics/auth/customizing/#django.contrib.auth.models.AbstractBaseUser.get_username
for more info
To be determined: Do we want to build a test for this ourselves? or are we at that point testing django functionality in django-binder, which could be considered redundant.