Skip to content

Conversation

@thecoolwinter
Copy link
Contributor

@thecoolwinter thecoolwinter commented Jun 3, 2025

Description

Fixes a bug with text attachments that ended on the newline character in a line. Eg:

A
B

Text attachment added for range (0..<2) should result in:

[Attachment]B

Right now it results in the following visible lines.

[Attachment]B

Also introduces the ability for text attachments to respond to being selected and draw their contents differently.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

With new behavior:

Screen.Recording.2025-06-03.at.10.15.54.AM.mov

@thecoolwinter thecoolwinter marked this pull request as draft June 3, 2025 15:35
@thecoolwinter thecoolwinter marked this pull request as ready for review June 5, 2025 16:27
@thecoolwinter thecoolwinter changed the title Merge Trailing Line when Adding Attachment Merge Trailing Line on Attachments, Select Attachments Jun 5, 2025
@thecoolwinter thecoolwinter merged commit 2508635 into CodeEditApp:main Jun 18, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the text-attachment-range-bounds branch June 18, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant