Skip to content

Conversation

herbert-allium
Copy link

@herbert-allium herbert-allium commented Oct 10, 2025

Summary

Allow db_engine = 'Shared' for atomic exchange, in addition to the Atomic and Replicated database engines.

The Clickhouse docs on the EXCHANGE statement mentions support for db_engine = 'Shared':
image

Checklist

Delete items not relevant to your PR:

  • A human-readable description of the changes was provided to include in CHANGELOG

Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

@koletzilla
Copy link
Contributor

Hi @herbert-allium ! Thanks for your contribution.

I thought this was already fixed by #498, but I see that also your change looks needed.

I'd like to take a deep look at this to understand why we have this duplicated check. Feel free to also make the needed changes so we don't have to keep two different lists of "databases that can use exchange"

@herbert-allium
Copy link
Author

@koletzilla I created engine_can_atomic_exchange in dbt/adapters/clickhouse/util. I'm unsure if this is the correct folder, I can also move it to somewhere else if you prefer.

@herbert-allium
Copy link
Author

Hi @koletzilla, how is this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants