This repository was archived by the owner on Mar 1, 2023. It is now read-only.
update CuArrays to 2.2 #1103
Merged
update CuArrays to 2.2 #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this is merged, we should look into getting rid of Manifests. |
|
Windows! |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
simonbyrne
force-pushed
the
sb/cuarrays
branch
6 times, most recently
from
f4651fd to
80abc34
Compare
7 tasks
simonbyrne
changed the title
simonbyrne
force-pushed
the
sb/cuarrays
branch
2 times, most recently
from
d629287 to
4af5139
Compare
|
bors r+ |
|
Build failed: |
|
Should the title of the PR be updated? |
|
bors r+ |
simonbyrne
changed the title
|
Build failed: |
|
Looks like the heat eqn result values changed. |
|
bors r+ |
|
bors r- |
|
Canceled. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 3, 2020
1103: update CuArrays to 2.2 r=simonbyrne a=simonbyrne # Description Fixes #1044, supercedes #1073 and #1099. 1123: Fix pre-compilation test, run unit tests with built system image r=jakebolewski a=jakebolewski Drop test macro, just execute script. move into a sep build stage I have - [ ] Written and run all necessary tests with CLIMA by including `tests/runtests.jl` - [ ] Followed all necessary [style guidelines](https://CliMA.github.io/CLIMA/latest/CodingConventions.html) and run `julia .dev/climaformat.jl .` - [ ] Updated the documentation to reflect changes from this PR. 1172: Separate cli arg parsing from initialization r=jakebolewski a=jakebolewski # Description Separates out cli argument processing from `ClimateMachine.init()` by defining a new method `ClimateMachine.cli()` that parses arguments and initializes ClimateMachine runtime. `ClimateMachine.init()` is preserved to allow for programmatic initialization when command line parsing is not needed (tests / notebooks / scripts). `ClimateMachine.cli` and `ClimateMachine.init` now take keyword arguments to allow for easy overloading for `ClimateMachine.Settings` at configuration / runtime. The experiment files have been updated to use `cli`, the tutorials I kept the same. Consistent overloading fallback behaviour is also defined: 1. cli arguments (if applicable) 2. keyword argument overloads 3. `CLIMATEMACHINE_SETTINGS_<VALUE_NAME>` process environment definitions 4. `ClimateMachine.Settings` default values. This allows for easy overloading of settings in batch scripts / container environments without having to define configuration files or change the driver file source code. We were currently doing this in kind of an add-hoc fashion. Closes #1167 1187: remove MPI installation from Documenter and Coverage r=simonbyrne a=simonbyrne # Description This is no longer necessary. 1192: Add comments to temperature profiles tests r=charleskawczynski a=charleskawczynski # Description - Adds some comments explaining temperature profiles tests Co-authored with: @tapios Co-authored-by: Simon Byrne <[email protected]> Co-authored-by: jakebolewski <[email protected]> Co-authored-by: Charles Kawczynski <[email protected]>
|
the CUDA artifact downloader is generating 16MB log files which breaks our Slurm CI... |
|
bors r- |
|
Canceled. |
|
bors try |
tryBuild succeeded: |
|
bors r+ |
|
Build failed: |
|
bors r+ |
|
Build succeeded:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1044, supercedes #1073 and #1099.
I have
tests/runtests.jljulia .dev/climaformat.jl .For review by CLIMA developers
julia .dev/format.jlhas been run in a separate commit.