Skip to content

Conversation

@cx-andre-pereira
Copy link
Contributor

@cx-andre-pereira cx-andre-pereira commented Oct 21, 2025

Reason for Proposed Changes

  • Currently there is no query to ensure that a "google_sql_database_instance" resource with a "POSTGRES" based "database_version" has the 'log_min_duration_statement' flag set to "-1", which is to say there is no minimum duration whatsoever, all logs are captured.

  • Quoting CIS_Google_Cloud_Platform_Foundation_Benchmark_v4.0.0 page 235: "Logging SQL statements may include sensitive information that should not be recorded in logs."

Proposed Changes

  • Implemented the missing query.
  • The query will flag for a specific instance : (all after ensuring "database_version" is POSTGRES based (possible values list))
    • Setting the "log_min_duration_statement" flag to a value that is not "-1" (default is "-1")

Tenable reference

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added feature New feature query New query feature labels Oct 21, 2025
@github-actions
Copy link
Contributor

kics-logo

KICS version: v2.1.13

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@github-actions github-actions bot added the terraform Terraform query label Oct 21, 2025
@cx-andre-pereira cx-andre-pereira marked this pull request as ready for review October 21, 2025 14:19
@cx-andre-pereira cx-andre-pereira requested a review from a team as a code owner October 21, 2025 14:19
…re_that_the_'log_min_duration_statement'_database_flag_for_cloud_sql_postgresql_instance_is_set_to_-1
…16628_15_6.2_PostgreSQL_Database_ensure_that_the_'log_min_duration_statement'_database_flag_for_cloud_sql_postgresql_instance_is_set_to_-1
Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the comment, nothing to add!
Let me know what you think @cx-andre-pereira, please.

@gitguardian
Copy link

gitguardian bot commented Nov 4, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
21271469 Triggered Generic Password a5026a2 assets/queries/terraform/azure/unrestricted_sql_server_access/test/positive3.tf View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature query New query feature terraform Terraform query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants