-
Notifications
You must be signed in to change notification settings - Fork 349
feat(query): implements "Beta - SQL DB Instance With Minimum Log Duration" #7784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…re_that_the_'log_min_duration_statement'_database_flag_for_cloud_sql_postgresql_instance_is_set_to_-1
…16628_15_6.2_PostgreSQL_Database_ensure_that_the_'log_min_duration_statement'_database_flag_for_cloud_sql_postgresql_instance_is_set_to_-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite the comment, nothing to add!
Let me know what you think @cx-andre-pereira, please.
assets/queries/terraform/gcp/sql_db_instance_with_minimum_log_duration/metadata.json
Outdated
Show resolved
Hide resolved
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 21271469 | Triggered | Generic Password | a5026a2 | assets/queries/terraform/azure/unrestricted_sql_server_access/test/positive3.tf | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.








Reason for Proposed Changes
Currently there is no query to ensure that a "google_sql_database_instance" resource with a "POSTGRES" based "database_version" has the 'log_min_duration_statement' flag set to "-1", which is to say there is no minimum duration whatsoever, all logs are captured.
Quoting CIS_Google_Cloud_Platform_Foundation_Benchmark_v4.0.0 page 235: "
Logging SQL statements may include sensitive information that should not be recorded in logs."Proposed Changes
Tenable reference
I submit this contribution under the Apache-2.0 license.