[Fix] Implement Drop for UnorderedChainStream and handle send errors. #4020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruseinov
requested review from
hanabi1224 and
sudo-shashank
and removed request for
a team
hanabi1224
reviewed
Mar 4, 2024
| match Arc::try_unwrap(self.seen) { | ||
| Ok(v) => v.into_inner(), | ||
| Err(v) => v.lock().clone(), | ||
| impl<DB, T> PinnedDrop for UnorderedChainStream<DB, T> { |
There was a problem hiding this comment.
I didn't find doc for implementing PinnedDrop with pin-project-lite, have you verified drop is being called?
There was a problem hiding this comment.
hanabi1224
approved these changes
Mar 4, 2024
|
@lemmih perhaps we could also modify the |
Sure. But I'm not sure I understand what is going on. |
Basically we couldn't move out of |
lemmih
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
PinnedDropforUnorderedChainStreamto make sure we cleanup automatically.UnorderedChainStreamis dropped, there is no need to panic when the receiver channel is closed.join_workersmethod as we are cleaning up inDrop.into_seenimplementation to work properly withDropand avoidingArcnuances.Reference issue to close (if applicable)
Closes #3991
Other information and links
Change checklist