Skip to content

Conversation

@aditya0by0
Copy link
Member

@aditya0by0 aditya0by0 commented Jun 30, 2025

@aditya0by0 aditya0by0 changed the title Hugging Face Api for self-downloadable model t Hugging Face Api for self-downloadable model Jun 30, 2025
@aditya0by0 aditya0by0 requested a review from sfluegel05 June 30, 2025 11:56
@aditya0by0 aditya0by0 self-assigned this Jun 30, 2025
Comment on lines +1 to +18
electra:
hugging_face:
repo_id: aditya0by0/python-chebifier
subfolder: electra
files:
ckpt: electra.ckpt
labels: classes.txt
package_name: chebai

resgated:
hugging_face:
repo_id: aditya0by0/python-chebifier
subfolder: resgated
files:
ckpt: resgated.ckpt
labels: classes.txt
package_name: chebai-graph

Copy link
Member Author

@aditya0by0 aditya0by0 Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to upload the models to chebai hugging face repo and update here

@aditya0by0
Copy link
Member Author

The api has been updated for ensemble please check

@sfluegel05
Copy link
Contributor

I merged the dev branch into this branch and was able to download the electra model from huggingface. I also created a config file (configs/huggingace_config.yml) based on my understanding of how to do that.

Some comments:

  • api is a separate directory with its own cli - is there a reason for that or can we put that under chebifier?
  • The api_registry.yml defines all the parameters for downloading the huggingface model. Can I refer to that from my config file (e.g. configs/huggingace_config.yml) with just the key of the model?
  • In hugging_face.py, a dictionary is returned which matches the keys expected by the ensemble (e.g. ckpt_path) to the keys used by the api_registry (e.g. ckpt). I would just use the same keys for both - this would reduce the chance of mistakes and allow us to add arbitrary files with arbitrary keys whenever necessary

@sfluegel05 sfluegel05 merged commit 90aedd4 into dev Jul 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chebai needs in-code downloadable models

3 participants