Attempt to work around warning spam from Unity physics engine #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Detected one or more triangles where the distance between any 2 vertices is greater than 500 units. The resulting Triangle Mesh can impact simulation and query stability. It is recommended to tessellate meshes that have large triangles." This commit tries to avoid this warning by scaling down the vertex positions of every tile mesh to fit inside a cube with a diagonal <= 1 unit. And then scale it back up to its proper size via the transformation matrix. It reduces the number of occurrences of this warning, but for some reason it doesn't eliminate them entirely.
kring
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tries to avoid this warning by scaling down the vertex positions of every tile mesh to fit inside a cube with a diagonal <= 1 unit. And then scale it back up to its proper size via the transformation matrix.
It reduces the number of occurrences of this warning, but for some reason it doesn't eliminate them entirely.
Draft because I'd like to eliminate these warnings entirely, and I don't know why it isn't working.
This PR also gives each mesh a name derived from the tile's content URL, so that the warning tells us which tile is the problem. This should probably be removed before this is merged because the URLs can get quite long.