Remove the trailing semicolon so that Derby can use this untouched #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows, for example, the ability to tweak the TableDesc after creation if you know what you are doing.
… so that the JDBCTap
can be ran locally. To use:
Tap myTap = new LocalJDBCTap( jdbcTap.getScheme(), SinkMode.UPDATE, jdbcTap, "Description" );
And enjoy!
…he rest with nulls.
…lts than we are interested in. For those cases, use the min of what we have and what we need.
…ariables, avoiding deprecated methods, etc.
…ourceField to the wrapping scheme.
…ired. Exceptions in derby resulted in an exception and warning if the other items were not closed.
…se to be tweaked from the caller after the fact.
|
Hey looks like there are a number of changes here, other than the trailing semicolon. Are you sure you are working off the right branch (scalding/develop)? |
Conflicts: src/jvm/com/twitter/maple/jdbc/db/DBOutputFormat.java
(a configuration issue), use SELECT * instead. This works for us as the particular case in question does not use this class.
LocalTapAdapter. I've not cut everyone over to it yet, but I have some code using this one fine.
second time. This resolves that issue. This also adds many more close's to ensure that we're closing them everywhere
|
We're moving this code here: twitter/scalding#779 but we are deprecating JDBC and recommending that people move to cascading-jdbc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are only two places in the DBXxxFormats which use a trailing semicolor and Derby is freaking out about them. This change removes them from the query entirely and it works fine on both Derby and MySQL.