Fixes crash caused by ValueNodeWrapper rendering incorrect value

[kyaw-t]

Fix for #169
Added a data parameter to the getInputComponent function so that the rejected value from inputProps.value doesn't get passed to the ValueNode.

[CarlosNZ]

Thanks a lot for spotting this and providing a quick fix. Looks good to me! I just have one tiny suggestion -- if we're passing data into the getInputComponent function, we don't need to also pass dataType.

[kyaw-t]

thanks for catching that! looks good 👍

[CarlosNZ]

Brilliant, much appreciated!

[CarlosNZ]

I'll make a new build and release later today 👍

[CarlosNZ]

Released in v1.22.3 now 👍

[CarlosNZ]

Hey, @kyaw-t , had to do an emergency fix for this, cos we inadverdantly caused a worse problem! #171 😆

Turns out a more thorough fix was just to remove the "update local state" call within the handleDataTypeChange and just let it re-render due to a data change -- that way it only changes if its actually been acceped by the onEdit function.

The problem with what we did yesterday is that it sends the data as the local value to each value component, which needs to be updated every keystroke, but data is only updated when "submitting" the value.

Anyway, here is the commit if you're interested: 6daabed

[kyaw-t]

Ah got it. I should've tested it a little more thoroughly. 😆
But glad the issue got resolved in the end though!