-
Couldn't load subscription status.
- Fork 4
Immutable dynamic object #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There should also be added CSharpTests.csproj to testing in CI |
Instead of relfection and SRTP, we constrain the inherited type to new() and after creation mutate its private field. No inline members needed, now all logic reside in assembly.
|
Questions to resolve:
|
Agreed on add/remove, maybe a bit more verbose
Here i would go for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. My comments are really minor ones, good stuff 💯
| # Visual Studio Version 16 | ||
| VisualStudioVersion = 16.0.31515.178 | ||
| # Visual Studio Version 17 | ||
| VisualStudioVersion = 17.0.31521.260 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this has any effect, but this is from VS Preview right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I will revert it once we understand that everything else is good enough
Usage:
F#
Simple
(
obj1is of typeImmutableDynamicObj)With inheritance
...
(
obj1is of typeQuack)C#
Simple
(
obj1is of typeImmutableDynamicObj)With inheritance
...
(
obj1is of typeMyDynamicObject)