Skip to content

removed redundant Material name getter and setter #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2023
Merged

removed redundant Material name getter and setter #396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef06f3b
removed redundant name getter and setter
nh916 Oct 19, 2023
28fb592
Merge branch 'develop' into material-redundant-getter-setter-removed
nh916 Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions src/cript/nodes/primary_nodes/material.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,45 +138,6 @@ def __init__(
keyword=keyword,
)

@property
@beartype
def name(self) -> str:
"""
material name

Examples
---------
>>> import cript
>>> my_material = cript.Material(
... name="my component material 1",
... identifier=[{"chem_formula": "my material chem formula"}],
... )
>>> my_material.name = "my new material name"

Returns
-------
str
material name
"""
return self._json_attrs.name

@name.setter
@beartype
def name(self, new_name: str) -> None:
"""
set the name of the material

Parameters
----------
new_name: str

Returns
-------
None
"""
new_attrs = replace(self._json_attrs, name=new_name)
self._update_json_attrs_if_valid(new_attrs)

@property
@beartype
def identifier(self) -> List[Dict[str, str]]:
Expand Down