refactored get_s3_client into a function in a aws_s3_utils.py file
#362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed some bulk from the `cript.API` class * wrote docstrings for `get_s3_client` * tested the code and it is working fine * formatted the whole thing with black * changed log to have `file` be capitalized for better UI
|
Merging to
|
|
@InnocentBug tried to format with trunk using WSL and it kept not working and not sure what to do to fix it, can you please update the PR when you get a chance? |
InnocentBug
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactored
get_s3_clientinto a function to reduce the bulk ofcript.APIand make it easier to navigate and handleChanges
cript.APIclassget_s3_clientfilebe capitalized for better UIKnown Issues
Notes
Checklist
CONTRIBUTORS.md) in the pull request source branch.