This repository was archived by the owner on Jun 15, 2024. It is now read-only.
Made changes to updates in response to code review comments #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nh916
approved these changes
Mar 27, 2023
| if isinstance(parsed_cell, dict): | ||
| cell_type = parsed_cell["type"] | ||
| cell_key = parsed_cell["key"] | ||
| cell_value = parsed_cell["value"] |
Contributor
There was a problem hiding this comment.
I recommend stripping it of white spaces as well
| elif cell_type == "identifier": | ||
| if cell_key == "Experiment or Inventory": | ||
| if cell_value == "I": | ||
| if cell_value.lower() == "i": |
Contributor
There was a problem hiding this comment.
I think this is fine, but if we wanted to make the code shorter we could do
inventory = cell_value.lower() == "i"
| group-obj | ||
| returns-tuple of dicts of objs | ||
| group-cript Group node | ||
| returns-tuple of dicts of reference nodes and citation nodes |
| elif cell_type == "property": | ||
| if parsed_cell["key"] == "use_existing": | ||
| use_existing = cellToBool(parsed_cell["value"]) | ||
| use_existing = is_cell_true(parsed_cell["value"]) |
| # try to get the material using its name | ||
| name_ = parsed_material["name"]["value"] | ||
| newProject = cript.Project.get( | ||
| mat_name = parsed_material["name"]["value"] |
Contributor
There was a problem hiding this comment.
I would not have known what mat_name if it wasn't for the comment. How come we didn't go with material_name ?
| return str(val).lower() != "false" | ||
|
|
||
|
|
||
| def copyMaterial(material, new_project, project): |
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.