Skip to content

Implement EIP-2718 #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 83 commits into from
Closed

Implement EIP-2718 #359

wants to merge 83 commits into from

Conversation

@trinhdn2
Copy link

@trinhdn2 trinhdn2 commented Jun 21, 2023 •
edited
Loading

This PR attemps to implement EIP-2718, planing the base code structure to implement more transaction types in the future.

These PRs must be merged first:

Checklist:

  • Move Message from types package to core
  • Generalize the types.TxData interface and implement LegacyTx, DynamicFeeTx
  • Implement eip2930Signer, londonSigner to handle new transaction types signing
  • Regen codec/rlp encoder for some structs
  • Implement the BASEFEE opcode and include it to EVM context
  • Modify RPC APIs to adapt new block/transaction formats and 3rd-party tools such as Hardhat, Remix, etc.
  • Fix NewTransactionsByPriceAndNonce to not removing special txs
  • Implement gas cap and eth_call timeout to prevent DoS
  • Decide if we need to keep or drop legacy receipt RLP core: drop legacy receipt types ethereum/go-ethereum#26225 => Should keep the current legacy receipt RLP type for now
  • Make sure that external tools like puppeth doesn't crash with pre and post London configs
  • Test log filter system with breaking changes
  • Backwards compatible tests
  • Make sure other network can map the correct new chain config at start

Refs:

trinhdn97 added 30 commits June 16, 2023 14:30
@trinhdn97
implements RLP encoding/decoding processing for structs
8253211
@trinhdn97
Update RLP lib
fa67be8
@trinhdn97
Implement RLP encoder code generation tool
9b5dadb
@trinhdn97
Update unit tests and benchmark
ddf35f8
@trinhdn97
Include RLPgen tool to CI
17e4876
@trinhdn97
Add benchmarks for types RLP encoding/decoding
aa7c4b4
@trinhdn97
Generate RLP encoder for some structs
ac89cd3
@trinhdn97
Convert status of receipts from uint to uint64
060f4ce 
Reference: ethereum/go-ethereum#16784
@trinhdn97
Move Message from package types to core
eb9b6c5 
Reference: ethereum/go-ethereum#25977
@trinhdn97
Add BaseFee to block and header struct
71c3cfe
@trinhdn97
Implement EIP-2718 base structure
d32c96d
@trinhdn97
Fix unit tests
2b9b5e1
@trinhdn97
Add transaction types to receipts
47a5cee
@trinhdn97
Generate JSON codec of AccessList
2746f63
@trinhdn97
Regen gencodec of some structs
a08a0e4
@trinhdn97
Implement eip2930Signer as a wrapper to handle all transaction types
ccdd83d
@trinhdn97
Add Berlin fork block to chain config to indicate EIP-2930 signer
112df1f
@trinhdn97
Implement londonSigner to handle dynamicFeeTx
baf7713
@trinhdn97
Check fork block
e5f3390
@trinhdn97
Fix comparing TxByPriceAndTime
b78e67e
@trinhdn97
Add block unit tests
fc3d7cf
@trinhdn97
Fix storage size of transactions
e5ee2d0
@trinhdn97
Add London signer to MakeSigner function
0ea51ca
@trinhdn97
Fix balanceToFee
83ff4fa
@trinhdn97
Add support for EIP-2718 in abi/bind package
529a6f4
@trinhdn97
Modify gas price oracle and API backend interface
5e0ffdc
@trinhdn97
Fix balanceTokenFee in doCall
6098691
@trinhdn97
Calculate header BaseFee in worker and chain maker
5179223
@trinhdn97
CalBaseFee
4980fca
@trinhdn97
Modify puppeth tool to adapt London hardfork
989bb51
@trinhdn2 trinhdn2 mentioned this pull request Jul 7, 2023
Closed
1 task
@tungng98 tungng98 deleted the branch BuildOnViction:upgrade-core-develop December 10, 2023 16:51
@tungng98 tungng98 closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trinhdn2 @tungng98 @trinhdn97