Add a dash pattern property to the LinkModel #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
First of all, thank you for all the work on this awesome library — it's been a pleasure to use.
I needed to create a dashed link line and noticed that while the model exposes Color and Width properties, there's currently no way to control the dash style directly. After digging into the code, I found that it's possible to achieve this via CSS, as demonstrated in LandingShowcaseDiagram.razor.css.
I believe adding a property to control basic dash styling — similar to how color and width are handled — could be a helpful addition and save users some time. For more advanced cases like animated dashes, CSS could still be used.
Thanks again for the great work