Skip to content

Conversation

@kircher1
Copy link
Contributor

  • Ensure atmosphere parameters get computed correctly when floating origin is enabled, assuming planet center is 0,0,0 in world space.
  • Use common dot product helper
  • NOTE: Minor breaking change to API; Include Camera as parameter to some existing observables that were previously Observable<void>.

- Ensure atmosphere parameters get computed correctly when floating origin is enabled, assuming planet center is 0,0,0 in world space.
- Use common dot product helper
- **NOTE:** Minor breaking change to API; Include `Camera` as parameter to some existing observables that were previously `Observable<void>`.
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 31, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 31, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 31, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 31, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 31, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 31, 2025

@sebavan sebavan merged commit 7282972 into BabylonJS:master Nov 3, 2025
20 checks passed
@kircher1 kircher1 deleted the atmo-float-fixes branch November 7, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants