Skip to content

Conversation

@tlupes
Copy link
Contributor

@tlupes tlupes commented Sep 30, 2025

Allow multiple certificate observers

Adds the ability to register multiple ICertificatesOberserver

Description

Currently only the most recently registered certificates observer will be used. This can be brittle as the observer can be used for multiple purposes and consumers could accidentally overwrite an existing observer with a custom one or vice versa. There is no functional reason to only support one, so this change will send notifications to all registered observers.

@tlupes tlupes requested a review from a team as a code owner September 30, 2025 15:03
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Maybe a small unit test?

Copy link
Contributor

@keegan-caruso keegan-caruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, otherwise, looks correct

@keegan-caruso keegan-caruso merged commit ae4937a into AzureAD:master Oct 7, 2025
5 checks passed
This was referenced Oct 13, 2025
This was referenced Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants