Skip to content

Android broker does not support adfs authority #5522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
Merged

Android broker does not support adfs authority #5522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5d7884
Android broker does not support adfs authority
fengga Oct 6, 2025
c3e6ff9
Update src/client/Microsoft.Identity.Client/Platforms/Android/Broker/…
fengga Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/client/Microsoft.Identity.Client/Platforms/Android/Broker/AndroidBrokerHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,13 @@ public bool IsBrokerInstalledAndInvokable(AuthorityType authorityType)
{
using (_logger.LogMethodDuration())
{
// ADFS is not supported with broker
if (authorityType == AuthorityType.Adfs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would have done smth like if (authorityType != AAD) { throw }

{
_logger.Info($"[Android broker] Unsupported authority type for broker: {authorityType}. Broker authentication will not be used.");
return false;
}

bool canInvoke = CanSwitchToBroker();
_logger.Verbose(()=>"[Android broker] Can invoke broker? " + canInvoke);

Expand Down