ImdsV2: Added Caching for the IMDS Endpoint Env Variable + Improved Unit Tests #5514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Robbie-Microsoft
commented
Oct 2, 2025
Robbie-Microsoft
commented
- Added caching so the method that builds a URI for IMDSv1 and IMDSv2 only checks the environment variable once, the first time
- this removes redundant logs
- Improved IMDSv2 unit tests so that the IMDS test environment variable is now used for IMDSv2
bgavrilMS
reviewed
Oct 3, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ImdsManagedIdentitySource.cs
Show resolved
Hide resolved
bgavrilMS
approved these changes
Oct 5, 2025
Robbie-Microsoft
merged commit 732c9d6
into
rginsburg/msiv2_feature_branch
3 checks passed
Robbie-Microsoft
deleted the
rginsburg/msiv2_cache_endpoint_env_variable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.