Remove some flaky tests that were just an overkill #5486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
approved these changes
Sep 18, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes flaky and problematic integration tests from the device code flow test suite to improve test reliability. The changes streamline the test suite by eliminating tests that were causing failures or were deemed excessive.
- Removes Arlington-specific device code flow tests (both standard and ADFS user scenarios)
- Eliminates MSA (Microsoft Account) user device code flow test that was failing due to environment issues
- Completely removes the Azure AD Kerberos feature test region including the main test method and helper function
Avery-Dunn
approved these changes
Sep 19, 2025
This was referenced Sep 26, 2025
This was referenced Oct 13, 2025
This was referenced Oct 20, 2025
Closed
Closed
Closed
This was referenced Oct 27, 2025
This was referenced Nov 7, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5485
Changes proposed in this request
This pull request removes several integration tests related to device code flow scenarios from the
DeviceCodeFlowIntegrationTest.csfile. The primary changes involve deleting tests for Arlington users, MSA users, and Azure AD Kerberos features, which streamlines the test suite in response to test failures.Test removals:
Kerberos feature test removal:
Testing
tests
Performance impact
n/a
Documentation