Introduces the extensibility API to allow users to add custom HTTP headers to token acquisition requests (under extensibility) #5440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Aug 15, 2025
src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForClientParameterBuilder.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
requested changes
Aug 15, 2025
gladjohn
force-pushed
the
gladjohn/expose_header_in_acq_client
branch
from
59e572f to
d43a52a
Compare
gladjohn
changed the title
WithExtraHttpHeaders(IDictionary<string, string> extraHttpHeaders) method to AcquireTokenForClientParameterBuilderWithExtraHttpHeaders on AcquireTokenForClient
gladjohn
changed the title
WithExtraHttpHeaders on AcquireTokenForClient
gladjohn
changed the title
bgavrilMS
approved these changes
Aug 18, 2025
gladjohn
force-pushed
the
gladjohn/expose_header_in_acq_client
branch
from
49d0634 to
dd54631
Compare
gladjohn
force-pushed
the
gladjohn/expose_header_in_acq_client
branch
from
9f514b0 to
262eaa6
Compare
trwalke
approved these changes
Aug 26, 2025
This was referenced Sep 12, 2025
Closed
Closed
This was referenced Sep 26, 2025
This was referenced Oct 13, 2025
Closed
This was referenced Oct 20, 2025
Closed
Closed
Open
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5439
Changes proposed in this request
This pull request adds a comprehensive new unit test class,
ExtraHttpHeadersTests, to verify the behavior of theWithExtraHttpHeadersAPI in the token acquisition flow. The tests ensure that custom HTTP headers are correctly sent, default headers remain unaffected by null input, user headers can override defaults, and repeated calls to set headers behave as expected.New test coverage for extra HTTP headers
ExtraHttpHeadersTestsclass to validateWithExtraHttpHeadersfunctionality inAcquireTokenForClient, including scenarios for sending custom headers, listing all headers, handling null values, overriding defaults, and ensuring last call precedence.TryGetHeader,EnumerateAllHeaders, andAssertHeaderExists) to facilitate header validation and assertions within the tests.Testing
unit tests
Performance impact
none
Documentation