Restore public AuthenticationResult constructor #5393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladjohn
force-pushed
the
gladjohn/msal-fix-bkchange
branch
from
95abaa6 to
4b78d93
Compare
bgavrilMS
approved these changes
Jul 21, 2025
jennyf19
approved these changes
Jul 21, 2025
Avery-Dunn
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5392
Changes proposed in this request
This pull request focuses on cleaning up deprecated code and improving test coverage for the
AuthenticationResultclass in the Microsoft Identity Client library. The most notable changes include the removal of[Obsolete]attributes from certain constructors and the addition of a comprehensive unit test to validate the consistency of the "for-test" constructor.Removal of deprecated attributes:
[Obsolete]and[EditorBrowsable(EditorBrowsableState.Never)]attributes from two constructors in theAuthenticationResultclass to make them publicly accessible again. These constructors were previously marked as deprecated but are now intended for continued use. (src/client/Microsoft.Identity.Client/AuthenticationResult.cs, [1] [2]Improvements in test coverage:
PublicTestConstructorCoversAllProperties, inAuthenticationResultTeststo ensure that the "for-test" constructor includes all public-settable or read-only properties ofAuthenticationResult, excluding specific exceptions (e.g., obsolete properties andBindingCertificate). (tests/Microsoft.Identity.Test.Unit/PublicApiTests/AuthenticationResultTests.cs, tests/Microsoft.Identity.Test.Unit/PublicApiTests/AuthenticationResultTests.csR21-L24)GetHybridSpaAuthCodetest, aligning with the cleanup of deprecated constructors. (tests/Microsoft.Identity.Test.Unit/PublicApiTests/AuthenticationResultTests.cs, tests/Microsoft.Identity.Test.Unit/PublicApiTests/AuthenticationResultTests.csL67)Testing
unit
Performance impact
none
Documentation