Fix for #5375 - Add a FormatResultAsync to IAuthenticationOperation #5376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
commented
Jul 9, 2025
bgavrilMS
commented
Jul 9, 2025
src/client/Microsoft.Identity.Client/Internal/Requests/ClientCredentialRequest.cs
Show resolved
Hide resolved
bgavrilMS
commented
Jul 9, 2025
bgavrilMS
force-pushed
the
bogavril/formatResult
branch
from
e6d762a to
8587584
Compare
gladjohn
reviewed
Jul 10, 2025
src/client/Microsoft.Identity.Client/AuthScheme/PoP/PopAuthenticationOperation.cs
Show resolved
Hide resolved
gladjohn
reviewed
Jul 10, 2025
src/client/Microsoft.Identity.Client/AuthScheme/PoP/PopAuthenticationOperation.cs
Show resolved
Hide resolved
gladjohn
approved these changes
Jul 10, 2025
jmprieur
reviewed
Jul 11, 2025
src/client/Microsoft.Identity.Client/AuthScheme/PoP/PopAuthenticationOperation.cs
Show resolved
Hide resolved
bgavrilMS
force-pushed
the
bogavril/formatResult
branch
from
98e72cf to
884b3c6
Compare
trwalke
reviewed
Jul 23, 2025
src/client/Microsoft.Identity.Client/AuthScheme/IAuthenticationOperation2.cs
Show resolved
Hide resolved
trwalke
reviewed
Jul 23, 2025
trwalke
reviewed
Jul 23, 2025
src/client/Microsoft.Identity.Client/AuthScheme/Bearer/BearerAuthenticationOperation.cs
Show resolved
Hide resolved
trwalke
reviewed
Jul 23, 2025
src/client/Microsoft.Identity.Client/AuthScheme/IAuthenticationOperation2.cs
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/AuthScheme/IAuthenticationOperation.cs
Outdated
Show resolved
Hide resolved
| public Func<OnBeforeTokenRequestData, Task> OnBeforeTokenRequestHandler { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Enables the developer to provide a custom authentication extension. |
There was a problem hiding this comment.
Keep this comment along with the added comment maybe.
neha-bhargava
approved these changes
Jul 29, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5375
Create an
IAuthenticationOperation2interface with the new method.