Revert SqlClient.SNI License Name from 5.2.3 to 5.2.0 #2705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenCerna2079
requested review from
Alekhya-Polavarapu,
Aniruddh25,
aaronburtle,
neeraj-sharma2592,
ravishetye,
rusamant,
sezal98,
sourabh1007,
souvikghosh04 and
vadeveka
as code owners
There was a problem hiding this comment.
Pull Request Overview
Updates the SqlClient license file to reflect the new package version.
- Adds a new license text file with version updated from 5.2.0 to 5.2.3.
Comments suppressed due to low confidence (1)
external_licenses/Microsoft.Data.SqlClient.SNI.5.2.3.License.txt:1
- [nitpick] Consider removing or archiving the previous Microsoft.Data.SqlClient.SNI.5.2.0 license file to prevent confusion and ensure that only the current version is presented.
MICROSOFT SOFTWARE LICENSE TERMS
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
RubenCerna2079
changed the title
RubenCerna2079
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
approved these changes
May 30, 2025
|
Please update the |
RubenCerna2079
added a commit
that referenced
this pull request
May 30, 2025
## Why make this change? Need to update license agreement to old version in script. SqlClient.SNI does not have a new version the same way the SqlClient package does with 5.2.3. ## What is this change? This changes the name of the license agreement from 5.2.3 to 5.2.0. Related to PR #2702 ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests ## Sample Request(s)
2 tasks
RubenCerna2079
added a commit
that referenced
this pull request
May 31, 2025
…2.3 to 5.2.0 (#2706) ## Why make this change? Need to update license agreement to old version in script. SqlClient.SNI does not have a new version the same way the SqlClient package does with 5.2.3. ## What is this change? This changes the name of the license agreement from 5.2.3 to 5.2.0. Related to PR #2702 Cherry-picked PR: - #2705 ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests ## Sample Request(s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Need to revert license agreement to old version in script.
SqlClient.SNIpackage does not have a 5.2.3 version the same way theSqlClientpackage does.What is this change?
This change reverts the name of the license agreement name in the
notice-generation.ps1script from 5.2.3 to 5.2.0.Related to PR #2702
How was this tested?
Sample Request(s)