This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Added the ability to set options for guzzle #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
suggested changes
Sep 4, 2018
| $certificatePath = Resources::EMPTY_STRING, | ||
| $certificateAuthorityPath = Resources::EMPTY_STRING | ||
| $certificateAuthorityPath = Resources::EMPTY_STRING, | ||
| $options = array() |
There was a problem hiding this comment.
Please, declare the argument type.
| $this->_requestUrl = null; | ||
| $this->_expectedStatusCodes = []; | ||
|
|
||
| $this->_config = array_merge($this->_config, $options); |
There was a problem hiding this comment.
Could the provided options be validated before hydrating $this->_config? (by instance, with an options resolver). BTW, if they are intended to be an associative array, + operator could be used instead of calling array_merge().
| * @return IHttpClient | ||
| */ | ||
| protected function httpClient() | ||
| protected function httpClient($options = array()) |
There was a problem hiding this comment.
Technically, this is a BC break (the method is extensible).
| * @return IServiceBus | ||
| */ | ||
| public function createServiceBusService($connectionString) | ||
| public function createServiceBusService($connectionString, $options = array()) |
There was a problem hiding this comment.
Technically, this is a BC break (the method is extensible).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.