[Az.ServiceFabric] Change from Basic to Standard SKUs for loadbalancers and public IP addresses for New-AzServiceFabricCluster and Add-AzServiceFabricNodeType
#28624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ancers and public IP addresses for `New-AzServiceFabricCluster` and `Add-AzServiceFabricNodeType`
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Service Fabric cluster infrastructure from deprecated Basic SKUs to Standard SKUs for load balancers and public IP addresses. The changes affect both the New-AzServiceFabricCluster and Add-AzServiceFabricNodeType commands as Basic SKUs are being phased out by Azure.
Key changes include:
- Migration from Basic to Standard SKUs for networking resources
- Updated ARM template configurations to use Static IP allocation with Standard SKUs
- Test data updates to reflect the new infrastructure requirements
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ServiceFabric/ServiceFabric/Template/Windows/template.json | Updated ARM template to use Standard SKUs for public IP and load balancer, changed allocation to Static |
| src/ServiceFabric/ServiceFabric/Commands/AddAzureRmServiceFabricNodeType.cs | Modified code to create Standard SKU public IP and load balancer resources |
| src/ServiceFabric/ServiceFabric/ChangeLog.md | Added changelog entry documenting the SKU migration |
| src/ServiceFabric/ServiceFabric.Test/SessionRecords/... | Updated test session recordings with new certificate thumbprints and resource configurations |
| src/ServiceFabric/ServiceFabric.Test/ScenarioTests/TestServiceFabric.cs | Updated test thumbprint for certificate validation |
| src/ServiceFabric/ServiceFabric.Test/ScenarioTests/Common.ps1 | Updated certificate URLs and thumbprints for test scenarios |
| src/ServiceFabric/ServiceFabric.Test/Resources/templateCNCert.json | Updated test template to use Standard SKUs |
| src/ServiceFabric/ServiceFabric.Test/Resources/template.json | Updated test template with Standard SKUs and parameterized durability/reliability levels |
Comments suppressed due to low confidence (1)
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Az.ServiceFabric] Change from Basic to Standard SKUs for loadbalancers and public IP addresses for
New-AzServiceFabricClusterandAdd-AzServiceFabricNodeType. Basic SKU are being deprecated in Azure.https://docs.azure.cn/en-us/load-balancer/load-balancer-basic-upgrade-guidance
https://learn.microsoft.com/en-us/azure/virtual-network/ip-services/public-ip-basic-upgrade-guidance
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.