Skip to content

Conversation

fzkhan
Copy link
Member

@fzkhan fzkhan commented Sep 18, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@fzkhan fzkhan marked this pull request as ready for review September 18, 2025 01:38
@Copilot Copilot AI review requested due to automatic review settings September 18, 2025 01:38
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure PowerShell DataTransfer module to use a newer preview API version (2025-05-30-preview) that introduces FlowProfile commands and deprecates several existing properties in favor of the new FlowProfile resource model.

Key changes include:

  • Addition of new FlowProfile cmdlets (Get, New, Remove, Update)
  • Updates to existing cmdlets with new parameters and deprecation notices
  • API version update from 2025-05-21 to 2025-05-30-preview

Reviewed Changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/DataTransfer/DataTransfer/help/*.md Updated help documentation for new FlowProfile cmdlets and existing cmdlets with API changes
src/DataTransfer/DataTransfer/Az.DataTransfer.psd1 Added new FlowProfile functions to module exports and updated generation date
src/DataTransfer/DataTransfer.sln Updated project GUID reference
src/DataTransfer/DataTransfer.Autorest/test/*.Tests.ps1 Added placeholder test files for new FlowProfile cmdlets
src/DataTransfer/DataTransfer.Autorest/generate-info.json Updated generation ID
src/DataTransfer/DataTransfer.Autorest/examples/*.md Added placeholder example files for new FlowProfile cmdlets
src/DataTransfer/DataTransfer.Autorest/docs/*.md Updated documentation for new and existing cmdlets with API changes
src/DataTransfer/DataTransfer.Autorest/UX/*.json Updated API version and added new FlowProfile resource definitions
src/DataTransfer/DataTransfer.Autorest/README.md Updated commit reference for newer API version
src/DataTransfer/DataTransfer.Autorest/Properties/AssemblyInfo.cs Updated assembly version from 0.1.0 to 1.0.0


### -ReplicationScenario
The data replication scenario handled by this FlowProfile.
Please not, that this value cannot be updated after creation.
Copy link

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the parameter description. 'Please not' should be 'Please note'.

Suggested change
Please not, that this value cannot be updated after creation.
Please note, that this value cannot be updated after creation.

Copilot uses AI. Check for mistakes.


### -ReplicationScenario
The data replication scenario handled by this FlowProfile.
Please not, that this value cannot be updated after creation.
Copy link

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the parameter description. 'Please not' should be 'Please note'.

Suggested change
Please not, that this value cannot be updated after creation.
Please note, that this value cannot be updated after creation.

Copilot uses AI. Check for mistakes.


### -MimeFilter
Defines the Media types (f.k.a MIME types) and associated file extensions to be filtered.
For more detail, please refer to the MimeTypeFiler model.
Copy link

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the parameter description. 'MimeTypeFiler' should be 'MimeTypeFilter'.

Suggested change
For more detail, please refer to the MimeTypeFiler model.
For more detail, please refer to the MimeTypeFilter model.

Copilot uses AI. Check for mistakes.


### -MimeFilter
Defines the Media types (f.k.a MIME types) and associated file extensions to be filtered.
For more detail, please refer to the MimeTypeFiler model.
Copy link

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the parameter description. 'MimeTypeFiler' should be 'MimeTypeFilter'.

Suggested change
For more detail, please refer to the MimeTypeFiler model.
For more detail, please refer to the MimeTypeFilter model.

Copilot uses AI. Check for mistakes.


### -MimeFilter
Defines the Media types (f.k.a MIME types) and associated file extensions to be filtered.
For more detail, please refer to the MimeTypeFiler model.
Copy link

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the parameter description. 'MimeTypeFiler' should be 'MimeTypeFilter'.

Suggested change
For more detail, please refer to the MimeTypeFiler model.
For more detail, please refer to the MimeTypeFilter model.

Copilot uses AI. Check for mistakes.


### -MimeFilter
Defines the Media types (f.k.a MIME types) and associated file extensions to be filtered.
For more detail, please refer to the MimeTypeFiler model.
Copy link

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the parameter description. 'MimeTypeFiler' should be 'MimeTypeFilter'.

Suggested change
For more detail, please refer to the MimeTypeFiler model.
For more detail, please refer to the MimeTypeFilter model.

Copilot uses AI. Check for mistakes.

@fzkhan
Copy link
Member Author

fzkhan commented Sep 18, 2025

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 28579 in repo Azure/azure-powershell

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly self-assigned this Sep 18, 2025
@fzkhan
Copy link
Member Author

fzkhan commented Sep 22, 2025

@VeryEarly Seeing some weird behaviour from autorest here.

  • In the New-AzDataTransferFlow command, I am expecting new parameters including FlowProfile, as added in the API spec. However, the generated commands do not have them for New-AzDataTransferFlow, only for New-AzDataTransferConnection
  • I see two new commands Get-AzDataTransferAzureDataTransferFlowProfile and Get-AzDataTransferFlowProfile, when it should just be Get-AzDataTransferFlowProfile
  • Some parameters are getting renamed incorrectly: AntivirusSolutions is renamed as AntiviruAvSolution in New-AzDataTransferFlowProfile command.

I tried removing the directives I had added to see if they were the issue here, but it seems the output is still the same either way. Can you please take a look here?

@VeryEarly
Copy link
Collaborator

@VeryEarly Seeing some weird behaviour from autorest here.

  • In the New-AzDataTransferFlow command, I am expecting new parameters including FlowProfile, as added in the API spec. However, the generated commands do not have them for New-AzDataTransferFlow, only for New-AzDataTransferConnection
  • I see two new commands Get-AzDataTransferAzureDataTransferFlowProfile and Get-AzDataTransferFlowProfile, when it should just be Get-AzDataTransferFlowProfile
  • Some parameters are getting renamed incorrectly: AntivirusSolutions is renamed as AntiviruAvSolution in New-AzDataTransferFlowProfile command.

I tried removing the directives I had added to see if they were the issue here, but it seems the output is still the same either way. Can you please take a look here?

@fzkhan
Copy link
Member Author

fzkhan commented Sep 24, 2025

@VeryEarly Seeing some weird behaviour from autorest here.

  • In the New-AzDataTransferFlow command, I am expecting new parameters including FlowProfile, as added in the API spec. However, the generated commands do not have them for New-AzDataTransferFlow, only for New-AzDataTransferConnection
  • I see two new commands Get-AzDataTransferAzureDataTransferFlowProfile and Get-AzDataTransferFlowProfile, when it should just be Get-AzDataTransferFlowProfile
  • Some parameters are getting renamed incorrectly: AntivirusSolutions is renamed as AntiviruAvSolution in New-AzDataTransferFlowProfile command.

I tried removing the directives I had added to see if they were the issue here, but it seems the output is still the same either way. Can you please take a look here?

@VeryEarly

  • Makes sense, I did not notice it has been marked as read-only in the FlowProperties. Seems like a mistake, I will check with the backend team about this. Meanwhile, is there a way for autorest to consider these readOnly fields as params to our commands anyway? Maybe some config we can use here? It will take time to resolve this on the backend and deploy, so thinking if we can resolve this on the front end and take the backend in parallel.
  • This makes sense, I will see if I can rename the list one to include both in the same command
  • For this, I will rename it in the directives I think, should be okay.

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@VeryEarly VeryEarly changed the base branch from main to Az.DataTransfer-preview September 26, 2025 08:00
@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@fzkhan fzkhan changed the title [Az.DataTransfer] DoNotMerge: Switch to newer preview version with FlowProfiles commands [Az.DataTransfer] Switch to newer preview version with FlowProfiles commands Sep 28, 2025
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command is hidden and does not need any tests, we have custom cmdlets with tests that are exposing this command separately.

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit ae91343 into Azure:Az.DataTransfer-preview Sep 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants