Skip to content

Conversation

VeryEarly
Copy link
Collaborator

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings September 16, 2025 02:23
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes missing online version URLs in Azure Service Fabric PowerShell help documentation files. The changes add proper Microsoft Learn documentation links for four Service Fabric managed node type cmdlets that previously had empty online version fields.

  • Adds online version URLs pointing to Microsoft Learn documentation
  • Updates help metadata for four Service Fabric cmdlets related to managed node types

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/ServiceFabric/ServiceFabric/help/Start-AzServiceFabricManagedNodeType.md Adds online version URL for the Start cmdlet
src/ServiceFabric/ServiceFabric/help/Invoke-AzServiceFabricReimageManagedNodeType.md Adds online version URL for the Reimage cmdlet
src/ServiceFabric/ServiceFabric/help/Invoke-AzServiceFabricRedeployManagedNodeType.md Adds online version URL for the Redeploy cmdlet
src/ServiceFabric/ServiceFabric/help/Invoke-AzServiceFabricDeallocateManagedNodeType.md Adds online version URL for the Deallocate cmdlet and fixes schema line positioning

external help file: Microsoft.Azure.PowerShell.Cmdlets.ServiceFabric.dll-Help.xml
Module Name: Az.ServiceFabric
online version:
online version: https://learn.microsoft.com/powershell/module/az.servicefabric/invoke-azservicefabricdeallocatemanagednodetype
Copy link

Copilot AI Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema line is missing after adding the online version. The YAML front matter should include 'schema: 2.0.0' before the closing '---' delimiter to maintain consistency with the other files.

Suggested change
online version: https://learn.microsoft.com/powershell/module/az.servicefabric/invoke-azservicefabricdeallocatemanagednodetype
online version: https://learn.microsoft.com/powershell/module/az.servicefabric/invoke-azservicefabricdeallocatemanagednodetype
schema: 2.0.0

Copilot uses AI. Check for mistakes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what?

NoriZC
NoriZC previously approved these changes Sep 16, 2025
isra-fel
isra-fel previously approved these changes Sep 16, 2025
@VeryEarly VeryEarly merged commit 571636c into main Sep 16, 2025
12 checks passed
@VeryEarly VeryEarly deleted the yabo/fix-onlineversion branch September 16, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants