-
Notifications
You must be signed in to change notification settings - Fork 4.1k
adding ps support for firmwareanalysis 2025-08-02 #28496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds PowerShell support for Firmware Analysis services using the 2025-08-02 API version. It updates the module with new cmdlets, enhanced functionality, and improved documentation.
Key changes include:
- Addition of the
Get-AzFirmwareAnalysisUsageMetric
cmdlet for retrieving monthly usage information - Enhanced workspace management cmdlets with SKU parameters and async operation support
- Updated API version from 2024-01-10 to 2025-08-02
- Improved parameter naming consistency (e.g.,
Name
→Type
,GenerateUploadUrl
→Body
)
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
Az.FirmwareAnalysis.psd1 |
Updated module dependencies, version, and added new cmdlet exports |
help/*.md |
Updated documentation with new parameters, corrected capitalization, and improved descriptions |
docs/*.md |
Mirror documentation updates for AutoRest generated files |
README.md |
Updated API version references and simplified input file configuration |
Test and UX files | Added support for new cmdlets and updated API versions |
src/FirmwareAnalysis/FirmwareAnalysis.Autorest/docs/New-AzFirmwareAnalysisWorkspace.md
Show resolved
Hide resolved
src/FirmwareAnalysis/FirmwareAnalysis/help/Update-AzFirmwareAnalysisWorkspace.md
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Hi @TheDonLuke , please follow this instruction: https://eng.ms/docs/cloud-ai-platform/azure-core/azure-experiences-and-ecosystems/azure-portal-and-client-tools-ruhim/azure-cli-tools-azure-cli-powershell-and-terraform/azure-cli-tools/onboarding/azurepowershell/dev_guidance_codegen#test |
/azp run |
Commenter does not have sufficient privileges for PR 28496 in repo Azure/azure-powershell |
/azp run |
Commenter does not have sufficient privileges for PR 28496 in repo Azure/azure-powershell |
…wareAnalysisWorkspace.md Co-authored-by: Copilot <[email protected]>
…alysisWorkspace.md Co-authored-by: Copilot <[email protected]>
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Hi @TheDonLuke , |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Azure Pipelines successfully started running 3 pipeline(s). |
In my copy-pasting of the doc files, I had clobbered the examples since at the time I thought the examples were being copied over the docs when the build was run. I have no reasoning why I thought this would be the case
/azp run |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
/azp run |
Commenter does not have sufficient privileges for PR 28496 in repo Azure/azure-powershell |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
- $(repo)/specification/fist/resource-manager/Microsoft.IoTFirmwareDefense/stable/2024-01-10/summaries.json | ||
- $(repo)/specification/fist/resource-manager/Microsoft.IoTFirmwareDefense/stable/2024-01-10/common.json | ||
- $(repo)/specification/fist/resource-manager/Microsoft.IoTFirmwareDefense/stable/2024-01-10/operations.json | ||
- $(repo)/specification/fist/resource-manager/Microsoft.IoTFirmwareDefense/stable/2025-08-02/iotfirmwaredefense.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this swagger the merge of all the previously referenced swaggers? Are there any gaps in APIs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, when we changed to typespec generating the swagger it output a single file instead of all the handwritten swaggers we had before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test cases need to be re-recorded after API upgrade
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
hopefully these don't get overwritten during the build process or something
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.