Skip to content

Conversation

TheDonLuke
Copy link
Member

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings September 2, 2025 20:42
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds PowerShell support for Firmware Analysis services using the 2025-08-02 API version. It updates the module with new cmdlets, enhanced functionality, and improved documentation.

Key changes include:

  • Addition of the Get-AzFirmwareAnalysisUsageMetric cmdlet for retrieving monthly usage information
  • Enhanced workspace management cmdlets with SKU parameters and async operation support
  • Updated API version from 2024-01-10 to 2025-08-02
  • Improved parameter naming consistency (e.g., NameType, GenerateUploadUrlBody)

Reviewed Changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Az.FirmwareAnalysis.psd1 Updated module dependencies, version, and added new cmdlet exports
help/*.md Updated documentation with new parameters, corrected capitalization, and improved descriptions
docs/*.md Mirror documentation updates for AutoRest generated files
README.md Updated API version references and simplified input file configuration
Test and UX files Added support for new cmdlets and updated API versions

@isra-fel
Copy link
Member

isra-fel commented Sep 2, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly self-assigned this Sep 4, 2025
@VeryEarly
Copy link
Collaborator

@TheDonLuke
Copy link
Member Author

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 28496 in repo Azure/azure-powershell

@eatkimchee
Copy link
Member

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 28496 in repo Azure/azure-powershell

@isra-fel
Copy link
Member

isra-fel commented Sep 4, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

VeryEarly commented Sep 5, 2025

Hi @TheDonLuke ,

please follow this instruction: https://eng.ms/docs/cloud-ai-platform/azure-core/azure-experiences-and-ecosystems/azure-portal-and-client-tools-ruhim/azure-cli-tools-azure-cli-powershell-and-terraform/azure-cli-tools/onboarding/azurepowershell/dev_guidance_codegen#test to update examples, tests, and changelog

Hi @TheDonLuke ,
Please find instructions to properly fix examples and tests in this doc, thanks.

@isra-fel
Copy link
Member

isra-fel commented Sep 8, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Sep 9, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

In my copy-pasting of the doc files, I had clobbered the examples
since at the time I thought the examples were being copied over the docs
when the build was run. I have no reasoning why I thought this would be
the case
@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@eatkimchee
Copy link
Member

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 28496 in repo Azure/azure-powershell

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

- $(repo)/specification/fist/resource-manager/Microsoft.IoTFirmwareDefense/stable/2024-01-10/summaries.json
- $(repo)/specification/fist/resource-manager/Microsoft.IoTFirmwareDefense/stable/2024-01-10/common.json
- $(repo)/specification/fist/resource-manager/Microsoft.IoTFirmwareDefense/stable/2024-01-10/operations.json
- $(repo)/specification/fist/resource-manager/Microsoft.IoTFirmwareDefense/stable/2025-08-02/iotfirmwaredefense.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this swagger the merge of all the previously referenced swaggers? Are there any gaps in APIs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when we changed to typespec generating the swagger it output a single file instead of all the handwritten swaggers we had before

Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test cases need to be re-recorded after API upgrade

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

hopefully these don't get overwritten during the build process or
something
@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit 263b440 into Azure:main Sep 12, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants