Skip to content

Conversation

audunn
Copy link
Member

@audunn audunn commented Aug 14, 2025

Description

This PR updates ANF to api-version 2025-06-01, adds Split-AzNetAppFilesCloneFromParent cmdLet

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings August 14, 2025 11:18
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the Azure NetApp Files (ANF) PowerShell module to use API version 2025-06-01, enhancing pool and volume functionality with new features for advanced throughput control and short-term clone splitting.

  • Bumps NetApp Files API from 2025-03-01 to 2025-06-01
  • Adds CustomThroughputMibps parameter for manual QoS pool throughput control with Flexible service level
  • Introduces Split-AzNetAppFilesCloneFromParent cmdlet for splitting clones from parent volumes

Reviewed Changes

Copilot reviewed 23 out of 72 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
help/*.md Updates documentation for new CustomThroughputMibps parameter and new Split cmdlet
Volume/SplitCloneFromParent.cs Implements new cmdlet for splitting clone volumes from parent
Volume/NewNetAppFilesVolume.cs Adds ShortTermClone volume type and AcceptGrowCapacityPoolForShortTermCloneSplit parameter
Pool/*.cs Adds CustomThroughputMibps parameter to pool creation and update cmdlets
Models/*.cs Updates model classes to support new properties
Helpers/ModelExtensions.cs Maps new API properties to PowerShell object models
ChangeLog.md Documents API version update and new features
Test files Updates test recordings and adds test for new split functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@NoriZC
Copy link
Contributor

NoriZC commented Aug 14, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@audunn
Copy link
Member Author

audunn commented Aug 14, 2025

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 28393 in repo Azure/azure-powershell

@NoriZC
Copy link
Contributor

NoriZC commented Aug 15, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@audunn
Copy link
Member Author

audunn commented Aug 15, 2025

CustomThroughputMibps is flagged as plural, but is not a plural word mibs is abbreviation. Changed to CustomThroughput

@audunn
Copy link
Member Author

audunn commented Aug 15, 2025

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 28393 in repo Azure/azure-powershell

@NoriZC NoriZC self-assigned this Aug 18, 2025
@NoriZC
Copy link
Contributor

NoriZC commented Aug 18, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@NoriZC
Copy link
Contributor

NoriZC commented Aug 18, 2025

Hi@audunn Please see the below static analysis error:
"Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
"Az.NetAppFiles","Microsoft.Azure.Commands.NetAppFiles.Snapshot.SplitCloneFromParent","Split-AzNetAppFilesCloneFromParent","1","8100","Split-AzNetAppFilesCloneFromParent Does not support ShouldProcess but the cmdlet verb Split indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@audunn
Copy link
Member Author

audunn commented Aug 18, 2025

Hi@audunn Please see the below static analysis error: "Module","ClassName","Target","Severity","ProblemId","Description","Remediation" "Az.NetAppFiles","Microsoft.Azure.Commands.NetAppFiles.Snapshot.SplitCloneFromParent","Split-AzNetAppFilesCloneFromParent","1","8100","Split-AzNetAppFilesCloneFromParent Does not support ShouldProcess but the cmdlet verb Split indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"

updated

@audunn
Copy link
Member Author

audunn commented Aug 18, 2025

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 28393 in repo Azure/azure-powershell

@NoriZC
Copy link
Contributor

NoriZC commented Aug 19, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@NoriZC NoriZC merged commit be5fe50 into Azure:main Aug 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants