Skip to content

[Az.ContainerRegistry] Update generation tool version: autorest.powershell v3->v4 #28382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lijinpei2008
Copy link
Contributor

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@lijinpei2008 lijinpei2008 marked this pull request as ready for review August 18, 2025 03:46
@Copilot Copilot AI review requested due to automatic review settings August 18, 2025 03:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the autorest.powershell generation tool from v3 to v4 for the Az.ContainerRegistry module, resulting in comprehensive changes to help documentation and parameter type definitions.

Key changes:

  • Updates API signatures from specific enumeration types to generic string types across all cmdlets
  • Enhances cmdlet parameter sets with additional JSON and identity-based operations
  • Introduces new update cmdlets for ExportPipeline and ImportPipeline
  • Updates model references to use simplified namespace paths

Reviewed Changes

Copilot reviewed 118 out of 119 changed files in this pull request and generated 5 comments.

File Description
help/*.md Updates parameter types from enums to strings and adds new parameter sets for JSON operations
Az.ContainerRegistry.psd1 Updates module metadata and adds new exported functions
ContainerRegistry.sln Updates solution file with new project structure and configurations
test/*.ps1 Adds test files for new Update cmdlets

@@ -8,28 +8,50 @@ schema: 2.0.0
# Update-AzContainerRegistryWebhook

## SYNOPSIS
Updates a webhook with the specified parameters.
Update a webhook with the specified parameters.
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SYNOPSIS should maintain consistent grammar. Change 'Update a webhook' to 'Updates a webhook' to match the original pattern and maintain consistency with other cmdlets.

Suggested change
Update a webhook with the specified parameters.
Updates a webhook with the specified parameters.

Copilot uses AI. Check for mistakes.

@@ -8,29 +8,51 @@ schema: 2.0.0
# Update-AzContainerRegistryToken

## SYNOPSIS
Updates a token with the specified parameters.
Update a token with the specified parameters.
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SYNOPSIS should maintain consistent grammar. Change 'Update a token' to 'Updates a token' to match the original pattern and maintain consistency with other cmdlets.

Suggested change
Update a token with the specified parameters.
Updates a token with the specified parameters.

Copilot uses AI. Check for mistakes.

@@ -8,7 +8,7 @@ schema: 2.0.0
# Update-AzContainerRegistryScopeMap

## SYNOPSIS
Updates a scope map with the specified parameters.
Update a scope map with the specified parameters.
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SYNOPSIS should maintain consistent grammar. Change 'Update a scope map' to 'Updates a scope map' to match the original pattern and maintain consistency with other cmdlets.

Suggested change
Update a scope map with the specified parameters.
Updates a scope map with the specified parameters.

Copilot uses AI. Check for mistakes.

@@ -8,7 +8,7 @@ schema: 2.0.0
# Update-AzContainerRegistryAgentPool

## SYNOPSIS
Updates an agent pool with the specified parameters.
Update an agent pool with the specified parameters.
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SYNOPSIS should maintain consistent grammar. Change 'Update an agent pool' to 'Updates an agent pool' to match the original pattern and maintain consistency with other cmdlets.

Suggested change
Update an agent pool with the specified parameters.
Updates an agent pool with the specified parameters.

Copilot uses AI. Check for mistakes.

@@ -8,45 +8,43 @@ schema: 2.0.0
# Update-AzContainerRegistry

## SYNOPSIS
Updates a container registry with the specified parameters.
Update a container registry with the specified parameters.
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SYNOPSIS should maintain consistent grammar. Change 'Update a container registry' to 'Updates a container registry' to match the original pattern and maintain consistency with other cmdlets.

Suggested change
Update a container registry with the specified parameters.
Updates a container registry with the specified parameters.

Copilot uses AI. Check for mistakes.

@lijinpei2008 lijinpei2008 marked this pull request as draft August 18, 2025 04:04
@lijinpei2008 lijinpei2008 added the Breaking Change Release This PR contains breaking change label Aug 18, 2025
Copy link

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Release This PR contains breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant