Skip to content

Conversation

blueww
Copy link
Member

@blueww blueww commented Jul 24, 2025

Description

The design review is raised: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1502

target to release on 8/5.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings July 24, 2025 05:45
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the first preview release of the Azure PowerShell StorageDiscovery module, providing cmdlets for managing StorageDiscoveryWorkspace resources and scope objects for Azure Storage discovery functionality.

Key Changes:

  • Added complete Az.StorageDiscovery module infrastructure with AutoRest-generated cmdlets
  • Implemented StorageDiscoveryWorkspace CRUD operations (Create, Read, Update, Delete)
  • Added StorageDiscoveryScope object creation functionality for workspace configuration

Reviewed Changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated 3 comments.

File Description
tools/CreateMappings_rules.json Added StorageDiscovery module mapping
src/StorageDiscovery/StorageDiscovery/ Main module configuration and help documentation
src/StorageDiscovery/StorageDiscovery.Autorest/ AutoRest-generated PowerShell module with cmdlets and tests


## EXAMPLES

### Example 1: Get a workspace proeprties
Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in the example title. 'proeprties' should be 'properties'.

Suggested change
### Example 1: Get a workspace proeprties
### Example 1: Get a workspace properties

Copilot uses AI. Check for mistakes.

@@ -0,0 +1,112 @@
### Example 1: Get a workspace proeprties
Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in the example title. 'proeprties' should be 'properties'.

Suggested change
### Example 1: Get a workspace proeprties
### Example 1: Get a workspace properties

Copilot uses AI. Check for mistakes.


## EXAMPLES

### Example 1: Get a workspace proeprties
Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in the example title. 'proeprties' should be 'properties'.

Suggested change
### Example 1: Get a workspace proeprties
### Example 1: Get a workspace properties

Copilot uses AI. Check for mistakes.

@YanaXu YanaXu merged commit b9cd199 into Azure:main Jul 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants