Skip to content

Conversation

YanaXu
Copy link
Contributor

@YanaXu YanaXu commented Jul 16, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings July 16, 2025 07:28
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR skips failing RecoveryServices tests by adding Skip attributes to test methods that are currently broken and awaiting fixes. The changes disable 4 specific test methods across the Site Recovery and Backup test suites to prevent test failures while fixes are being developed.

  • Adds Skip attributes to broken A2A managed disk replication configuration tests
  • Skips failing A2A container test
  • Disables broken SQL container registration error test

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
AsrA2ATests.cs Skips 3 A2A test methods related to managed disk replication configuration and container operations
ContainerTests.cs Skips 1 SQL container registration error test method
Comments suppressed due to low confidence (4)

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.cs:53

  • The skip message is generic and unhelpful for debugging. Consider providing more specific information about what is broken or a reference to a tracking issue (e.g., 'Skip = "Failing due to authentication issues - tracked in issue #1234"').
        [Fact(Skip = "The test is broken and waiting for a fix.")]

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.cs:63

  • The skip message is generic and unhelpful for debugging. Consider providing more specific information about what is broken or a reference to a tracking issue (e.g., 'Skip = "Failing due to authentication issues - tracked in issue #1234"').
        [Fact(Skip = "The test is broken and waiting for a fix.")]

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.cs:101

  • The skip message is generic and unhelpful for debugging. Consider providing more specific information about what is broken or a reference to a tracking issue (e.g., 'Skip = "Failing due to authentication issues - tracked in issue #1234"').
        [Fact(Skip = "The test is broken and waiting for a fix.")]

src/RecoveryServices/RecoveryServices.Backup.Test/ScenarioTests/AzureWorkload/ContainerTests.cs:63

  • The skip message is generic and unhelpful for debugging. Consider providing more specific information about what is broken or a reference to a tracking issue (e.g., 'Skip = "Failing due to authentication issues - tracked in issue #1234"').
        [Fact(Skip = "The test is broken and waiting for a fix.")]

@YanaXu
Copy link
Contributor Author

YanaXu commented Jul 16, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@YanaXu
Copy link
Contributor Author

YanaXu commented Jul 17, 2025

Hi @riyanshpal, please fix them later and remove the skip line. Thanks.

@vidai-msft vidai-msft merged commit 8f31d0f into main Jul 17, 2025
12 checks passed
@YanaXu YanaXu deleted the yanxu/skip_test branch July 25, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants