Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ public static void GetPSSubProtectionPolicy(AzureVmWorkloadPolicy azureVmWorkloa
}
else if (string.Compare(subProtectionPolicy.PolicyType, "Log") == 0)
{
// timeZone paased as input but not used in below method calls
// timeZone passed as input but not used in below method calls
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'paased' to 'passed' in the comment.

Suggested change
// timeZone passed as input but not used in below method calls
// timeZone passed as input; verify its usage in the methods below

Copilot uses AI. Check for mistakes.
azureVmWorkloadPolicyModel.LogBackupSchedulePolicy = PolicyHelpers.GetPSLogSchedulePolicy((ServiceClientModel.LogSchedulePolicy)
subProtectionPolicy.SchedulePolicy,
((ServiceClientModel.AzureVmWorkloadProtectionPolicy)serviceClientResponse.Properties).Settings.TimeZone);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public static List<RecoveryPointBase> FilterRPsBasedOnTier(List<RecoveryPointBas
}

/// <summary>
/// filter move readness based on target tier
/// filter move readiness based on target tier
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'readness' to 'readiness' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
/// <param name="recoveryPointList"></param>
/// <param name="targetTier"></param>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ string id
}

/// <summary>
/// Gets polcy name from the provided dictionary of key value pairs.
/// Gets policy name from the provided dictionary of key value pairs.
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'polcy' to 'policy' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
/// <param name="keyValuePairDict">Dictionary of UriEnum as key and value as value of corresponding URI enum</param>
/// <param name="id">ID of the resource</param>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public static void ValidateFullBackupRetentionPolicyWithTieringPolicy(LongTermRe
}

/// <summary>
/// Helper function to validate long term rentention policy and simple schedule policy.
/// Helper function to validate long term retention policy and simple schedule policy.
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'rentention' to 'retention' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
public static void ValidateLongTermRetentionPolicyWithSimpleSchedulePolicy(
LongTermRetentionPolicy ltrPolicy,
Expand Down Expand Up @@ -226,7 +226,7 @@ public static void ValidateLongTermRetentionPolicyWithSimpleSchedulePolicy(
}

/// <summary>
/// Helper function to validate long term rentention policy and simple schedule policy.
/// Helper function to validate long term retention policy and simple schedule policy.
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'rentention' to 'retention' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
public static void ValidateLongTermRetentionPolicyWithSimpleSchedulePolicy(
LongTermRetentionPolicy ltrPolicy,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public class AzureVmRecoveryPoint : AzureRecoveryPoint
public DateTime? RehydrationExpiryTime;

/// <summary>
/// Recovery point move rediness info
/// Recovery point move readiness info
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'rediness' to 'readiness' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
public IDictionary<string, RecoveryPointMoveReadinessInfo> RecoveryPointMoveReadinessInfo;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public class AzureWorkloadRecoveryPoint : AzureRecoveryPoint
public RecoveryPointTier RecoveryPointTier;

/// <summary>
/// Recovery point move rediness info
/// Recovery point move readiness info
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'rediness' to 'readiness' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
public IDictionary<string, RecoveryPointMoveReadinessInfo> RecoveryPointMoveReadinessInfo;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ public override void Validate()
}

/// <summary>
/// Base class for backup rentention policy.
/// Base class for backup retention policy.
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'rentention' to 'retention' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
public class RetentionPolicyBase : ObjectBase
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ public override string ToString()
}

/// <summary>
/// Weekly rentention schedule.
/// Weekly retention schedule.
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'rentention' to 'retention' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
public class WeeklyRetentionSchedule : RetentionScheduleBase
{
Expand Down Expand Up @@ -442,7 +442,7 @@ public override string ToString()
}

/// <summary>
/// Monthly rentention schedule.
/// Monthly retention schedule.
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'rentention' to 'retention' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
public class MonthlyRetentionSchedule : RetentionScheduleBase
{
Expand Down Expand Up @@ -528,7 +528,7 @@ public override string ToString()
}

/// <summary>
/// Yearly rentention schedule.
/// Yearly retention schedule.
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'rentention' to 'retention' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
public class YearlyRetentionSchedule : RetentionScheduleBase
{
Expand Down Expand Up @@ -625,7 +625,7 @@ public override string ToString()
}

/// <summary>
/// Daily rentention format.
/// Daily retention format.
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'rentention' to 'retention' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
public class DailyRetentionFormat
{
Expand Down Expand Up @@ -672,7 +672,7 @@ public override string ToString()
}

/// <summary>
/// Weekly rentention format.
/// Weekly retention format.
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'rentention' to 'retention' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
public class WeeklyRetentionFormat
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ public override void Validate()

DateTime windowStartTime = (DateTime)ScheduleWindowStartTime;

// If ScheduleWindowDuration is greator than (23:30 - ScheduleWindowStartTime) then throw exception
// If ScheduleWindowDuration is greater than (23:30 - ScheduleWindowStartTime) then throw exception
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'greator' to 'greater' in the comment.

Copilot uses AI. Check for mistakes.
// if non-UTC times (timeZones already allowed) are allowed then this exception needs to change
if (windowStartTime.Minute % 30 != 0 || windowStartTime.Second != 0 || windowStartTime.Millisecond != 0)
{
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@
<value>Unexpected ContainerType - expected:{0}, current:{1}</value>
</data>
<data name="AllRetentionSchedulesEmptyException" xml:space="preserve">
<value>All retention schedules are empty in RetentionPolicy. Alteast one is expected.</value>
<value>All retention schedules are empty in RetentionPolicy. At least one is expected.</value>
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'Alteast' to 'At least' in the resource string.

Copilot uses AI. Check for mistakes.
</data>
<data name="BackupAndRetentionTimesMismatch" xml:space="preserve">
<value>RetentionTime in retention schedule should be same as backup time specified in SchedulePolicy</value>
Expand Down Expand Up @@ -596,7 +596,7 @@ Please contact Microsoft for further assistance.</value>
<value>Both Inclusion and Exclusion lists provided. Please provide only one of them.</value>
</data>
<data name="TargetRGUnmanagedRestoreDuplicateParamsException" xml:space="preserve">
<value>Both RestoreAsUnmanagedDisks and TargetResourceGroupName can't be spceified. Please give Only one parameter and retry.</value>
<value>Both RestoreAsUnmanagedDisks and TargetResourceGroupName can't be specified. Please give Only one parameter and retry.</value>
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'spceified' to 'specified' in the resource string.

Copilot uses AI. Check for mistakes.
</data>
<data name="UnmanagedVMRestoreWarning" xml:space="preserve">
<value>This is a managed disk recovery point and hence please provide a target resource group for the managed disks to be restored into with the TargetResourceGroupName parameter. Otherwise, please explicitly state that the managed disks should be restored into the staging storage account as unmanaged disks with restoreAsUnmanagedDisks parameter</value>
Expand All @@ -614,7 +614,7 @@ Please contact Microsoft for further assistance.</value>
<value>Target ResourceGroup is not applicable and restore will proceed as unmanaged disk restore since this is unmanaged VM</value>
</data>
<data name="InvalidTargetStorageAccount" xml:space="preserve">
<value>Please provide a vaild target storage account</value>
<value>Please provide a valid target storage account</value>
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'vaild' to 'valid' in the resource string.

Copilot uses AI. Check for mistakes.
</data>
<data name="RecoveryPointVaultRecoveryTypeException" xml:space="preserve">
<value>Please ensure that the given RP recovery type is either 'VaultStandard' or SnapshotAndVaultStandard, or remove TargetZone</value>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public override void ExecuteCmdlet()
}

// Currently the containers API doesn't support any status level filtering
// Also the NotRegitered container isn't a valid scenario, so we're not allowing client filtering too
// Also the NotRegistered container isn't a valid scenario, so we're not allowing client filtering too
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'NotRegitered' to 'NotRegistered' in the comment.

Copilot uses AI. Check for mistakes.
// If the filtering is required in future we can add client side filtering
// Status = ContainerRegistrationStatus.Registered;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public class RegisterAzureRmRecoveryServicesBackupContainer
public string ResourceId { get; set; }

/// <summary>
/// When this option is specified, The contiane will be registered
/// When this option is specified, The container will be registered
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'contiane' to 'container' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
[Parameter(Mandatory = true, Position = 0, HelpMessage = ParamHelpMsgs.Item.Container,
ParameterSetName = ReRegisterParamSet, ValueFromPipelineByPropertyName = true)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class UndoAzureRmRecoveryServicesBackupContainerDeletion
internal const string UndeleteParamSet = "undelete";

/// <summary>
/// Specifies the backup contianer to be rehydrated
/// Specifies the backup container to be rehydrated
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'contianer' to 'container' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
[Parameter(Mandatory = true, Position = 0, HelpMessage = ParamHelpMsgs.Item.Container,
ParameterSetName = UndeleteParamSet, ValueFromPipelineByPropertyName = true)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public class GetAzureRmRecoveryServicesBackupItem : RSBackupVaultCmdletBase
public string FriendlyName { get; set; }

/// <summary>
/// Fetches the VM Bakup Items from Secondary Region.
/// Fetches the VM Backup Items from Secondary Region.
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'Bakup' to 'Backup' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
[Parameter(Mandatory = false, HelpMessage = ParamHelpMsgs.Common.UseSecondaryReg)]
public SwitchParameter UseSecondaryRegion;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public class NewAzureRmRecoveryServicesBackupProtectionPolicy : RSBackupVaultCmd
public RetentionPolicyBase RetentionPolicy { get; set; }

/// <summary>
/// Schedule policy object assoicated with the policy to be created
/// Schedule policy object associated with the policy to be created
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'assoicated' to 'associated' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
[Parameter(Position = 5, Mandatory = false, HelpMessage = ParamHelpMsgs.Policy.SchedulePolicy,
ValueFromPipelineByPropertyName = true)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public override void ExecuteCmdlet()
targetVaultName = HelperUtils.GetVaultNameFromId(keyValueDict, TargetItem.Id);
targetSubscriptionId = HelperUtils.GetSubscriptionIdFromId(keyValueDict, TargetItem.Id);

// check if the TragetItem provided is of workload type
// check if the TargetItem provided is of workload type
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'TragetItem' to 'TargetItem' in the comment.

Copilot uses AI. Check for mistakes.
if (!string.Equals(((AzureWorkloadProtectableItem)TargetItem).ProtectableItemType,
ProtectableItemType.SQLInstance.ToString()))
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public override void ExecuteCmdlet()

param.Properties.SoftDeleteFeatureState = ((SoftDeleteFeatureState != null) && SoftDeleteFeatureState.ToLower() == "alwayson") ? "AlwaysON" : ((SoftDeleteFeatureState != null) ? SoftDeleteFeatureState + "d" : currentConfig.Properties.SoftDeleteFeatureState);

param.Properties.SoftDeleteRetentionPeriodInDays = SoftDeleteRetentionPeriodInDays ?? currentConfig.Properties.SoftDeleteRetentionPeriodInDays; // chck - should we get from vault API / MUA angle ?
param.Properties.SoftDeleteRetentionPeriodInDays = SoftDeleteRetentionPeriodInDays ?? currentConfig.Properties.SoftDeleteRetentionPeriodInDays; // check - should we get from vault API / MUA angle ?
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'chck' to 'check' in the comment.

Copilot uses AI. Check for mistakes.

if(SoftDeleteFeatureState !=null && SoftDeleteFeatureState.ToLower() == "alwayson")
{
Expand All @@ -113,7 +113,7 @@ public override void ExecuteCmdlet()

bool isMUAProtected = checkMUAForSoftDelete(currentConfig, param);

BackupResourceVaultConfigResource result = ServiceClientAdapter.SetVaultProperty(vaultName, resourceGroupName, param, plainToken, isMUAProtected); // chck - should call vault API ?
BackupResourceVaultConfigResource result = ServiceClientAdapter.SetVaultProperty(vaultName, resourceGroupName, param, plainToken, isMUAProtected); // check - should call vault API ?
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'chck' to 'check' in the comment.

Copilot uses AI. Check for mistakes.
WriteObject(result.Properties);
}
else if (EncryptionKeyId != null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets
{
/// <summary>
/// Used for validtaing Data Source Move operation. The command runs successfully if the DS move is feasible.
/// Used for validating Data Source Move operation. The command runs successfully if the DS move is feasible.
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'validtaing' to 'validating' in the comment.

Suggested change
/// Used for validating Data Source Move operation. The command runs successfully if the DS move is feasible.
/// Used for validating Data Source Move operation. The command runs successfully if the DS move is feasible.

Copilot uses AI. Check for mistakes.
/// </summary>
[Cmdlet("Test", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "RecoveryServicesDSMove", SupportsShouldProcess = true), OutputType(typeof(Boolean))]
public class TestAzureRMRecoveryServicesDSMove : RecoveryServicesBackupCmdletBase
Expand Down
4 changes: 2 additions & 2 deletions src/RecoveryServices/RecoveryServices.Backup/ParamHelpMsgs.cs
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ internal static class Item
public const string Container = "Container where the item resides";
public const string RemoveProtectionOption = "If this option is used, all the recovery points for this item will also be deleted and restoring will not be possible.";
public const string SuspendBackupOption = "If this option is used, all the recovery points for this item will expire as per the retention policy.";
public const string ExpiryDate = "Retention period for the recovery points created by this backup operaiton";
public const string ExpiryDate = "Retention period for the recovery points created by this backup operation";
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'operaiton' to 'operation' in the help message.

Copilot uses AI. Check for mistakes.
public const string ForceOption = "Force disables backup protection (prevents confirmation dialog). This parameter is optional.";
public const string ForceSuspend = "Force suspends backup.";
public const string ExpiryDateTimeUTC = "Specifies an expiry time for the Recovery point as a DateTime object, " +
Expand Down Expand Up @@ -173,7 +173,7 @@ internal static class RestoreVM
public const string RestoreDiskList = "Specify which disks to recover of the backed up VM";
public const string RestoreAsUnmanagedDisks = "Use this switch to specify to restore as unmanaged disks";
public const string TargetZone = "Target zone to restore the disks";
public const string EdgeZone = "Switch parameter to indicate edge zone VM restore. This parameter can't be used in cross region and corss subscription restore scenario";
public const string EdgeZone = "Switch parameter to indicate edge zone VM restore. This parameter can't be used in cross region and cross subscription restore scenario";
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'corss' to 'cross' in the help message.

Copilot uses AI. Check for mistakes.
public const string RestoreAsManagedDisk = "Use this switch to specify to restore as managed disks.";
public const string UseSystemAssignedIdentity = "Use this switch to trigger MSI based restore with SystemAssigned Identity";
public const string UserAssignedIdentityId = "UserAssigned Identity Id to trigger MSI based restore with UserAssigned Identity";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ protected override void SetupHttpClientPipeline()

/// <summary>
/// Wrapper method which executes the cmdlet processing blocks.
/// Catches and logs any exception occuring during the execution.
/// Catches and logs any exception occurring during the execution.
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'occuring' to 'occurring' in the comment.

Copilot uses AI. Check for mistakes.
/// </summary>
/// <param name="action">Delegate representing the cmdlet processing block</param>
/// <param name="shouldProcess"></param>
Expand Down
4 changes: 2 additions & 2 deletions src/RecoveryServices/RecoveryServices/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
* Added CRR support for taiwannorth, taiwannorthwest region.
* Added breaking change notification for cmdlets whose output type is `ASRVaultSettings`.
* Added warning for Standard to Enhanced policy migration for AzureVMs.
* Updated Unregister-AzRecoveryServicesBackupContainer cmdlet to ouptput Job object if PassThru not given.
* Updated Unregister-AzRecoveryServicesBackupContainer cmdlet to output Job object if PassThru not given.
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'ouptput' to 'output' in the changelog.

Copilot uses AI. Check for mistakes.
* Fixed issue with Get-AzRecoveryServicesVaultSettingsFile cmdlet to return private endpoint state for backup.

## Version 6.7.0
Expand Down Expand Up @@ -414,7 +414,7 @@
* Updated table format for SQL in azure VM
* Added alternate method to fetch location in AzureFileShare
* Updated ScheduleRunDays in SchedulePolicy object according to timezone
* Made some attibutes read-only in Get-AzRecoveryServicesBackupWorkloadRecoveryConfig
* Made some attributes read-only in Get-AzRecoveryServicesBackupWorkloadRecoveryConfig
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'attibutes' to 'attributes' in the changelog.

Copilot uses AI. Check for mistakes.

## Version 1.2.0
* Added SnapshotRetentionInDays in Azure VM policy to support Instant RP
Expand Down
Loading