Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public static List<string> MapUserInputToAllowedFqdnTags(IEnumerable<string> use

var allowedFqdnTags = GetAzureFirewallAllowedFqdnTags(azureFirewallFqdnTagClient);

// Accept user input case insensistive
// Accept user input case insensitive
var userAcceptedFqdnTags = allowedFqdnTags.Aggregate(
new Dictionary<string, string>(),
(userAcceptedVersions, allowedFqdnTag) =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public override void Execute()
}

// Only one of DestinationAddress/DestinationIpGroup or DestinationFqdns is allowed
// Eventually we may want to have exclusitivity with IpGroup too but for now not doing that
// Eventually we may want to have exclusivity with IpGroup too but for now not doing that
if (((DestinationAddress != null) || (DestinationIpGroup != null)) && (DestinationFqdn != null))
{
throw new ArgumentException("Both DestinationAddress or DestinationIpGroup and DestinationFqdns not allowed");
Expand Down
8 changes: 4 additions & 4 deletions src/Network/Network/Common/NetworkClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ public async Task<AzureOperationResponse<string>> GeneratevpnclientpackageWithHt
DateTime startTime = DateTime.UtcNow;
DateTime giveUpAt = DateTime.UtcNow.AddMinutes(3);

// Send the Get locationResults request for operaitonId till either we get StatusCode 200 or it time outs (3 minutes in this case)
// Send the Get locationResults request for operationId till either we get StatusCode 200 or it time outs (3 minutes in this case)
while (true)
{
HttpRequestMessage newHttpRequest = new HttpRequestMessage();
Expand Down Expand Up @@ -364,7 +364,7 @@ public async Task<AzureOperationResponse<string>> GenerateVpnProfileWithHttpMess
DateTime startTime = DateTime.UtcNow;
DateTime giveUpAt = DateTime.UtcNow.AddMinutes(3);

// Send the Get locationResults request for operaitonId till either we get StatusCode 200 or it time outs (3 minutes in this case)
// Send the Get locationResults request for operationId till either we get StatusCode 200 or it time outs (3 minutes in this case)
while (true)
{
HttpRequestMessage newHttpRequest = new HttpRequestMessage();
Expand Down Expand Up @@ -503,7 +503,7 @@ public async Task<AzureOperationResponse<string>> GetVpnProfilePackageUrlWithHtt
DateTime startTime = DateTime.UtcNow;
DateTime giveUpAt = DateTime.UtcNow.AddMinutes(3);

// Send the Get locationResults request for operaitonId till either we get StatusCode 200 or it time outs (3 minutes in this case)
// Send the Get locationResults request for operationId till either we get StatusCode 200 or it time outs (3 minutes in this case)
while (true)
{
HttpRequestMessage newHttpRequest = new HttpRequestMessage();
Expand Down Expand Up @@ -785,7 +785,7 @@ public async Task<AzureOperationResponse<string>> ExecuteOperationWithHttpMessag
DateTime startTime = DateTime.UtcNow;
DateTime giveUpAt = DateTime.UtcNow.AddMinutes(3);

// Send the Get locationResults request for operaitonId till either we get StatusCode 200 or it time outs (3 minutes in this case)
// Send the Get locationResults request for operationId till either we get StatusCode 200 or it time outs (3 minutes in this case)
while (true)
{
HttpRequestMessage newHttpRequest = new HttpRequestMessage();
Expand Down
6 changes: 3 additions & 3 deletions src/Network/Network/Common/NetworkResourceManagerProfile.cs
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ private static void Initialize()
// MNM to CNM
cfg.CreateMap<MNM.IPAddressAvailabilityResult, CNM.PSIPAddressAvailabilityResult>();

// Avaliable endpoint services
// Available endpoint services
// CNM to MNM
cfg.CreateMap<CNM.PSEndpointServiceResult, MNM.EndpointServiceResult>();

Expand Down Expand Up @@ -973,7 +973,7 @@ private static void Initialize()
// MNM to CNM
cfg.CreateMap<MNM.NetworkSecurityGroup, CNM.PSNetworkSecurityGroup>();

// NetworkSecrityRule
// NetworkSecurityRule
// CNM to MNM
cfg.CreateMap<CNM.PSSecurityRule, MNM.SecurityRule>()
.AfterMap((src, dest) =>
Expand Down Expand Up @@ -1155,7 +1155,7 @@ private static void Initialize()
cfg.CreateMap<MNM.ExpressRouteCircuitRoutesTable, CNM.PSExpressRouteCircuitRoutesTable>();
cfg.CreateMap<MNM.ExpressRouteCircuitRoutesTableSummary, CNM.PSExpressRouteCircuitRoutesTableSummary>();

// ExoressRouteCircuitAuthorization
// ExpressRouteCircuitAuthorization
// CNM to MNM
cfg.CreateMap<CNM.PSExpressRouteCircuitAuthorization, MNM.ExpressRouteCircuitAuthorization>();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public override void Execute()
this.VirtualHubName = parsedResourceId.ResourceName;
}

// this will thorw if hub does not exist.
// this will throw if hub does not exist.
IsParentVirtualHubPresent(this.ResourceGroupName, this.VirtualHubName);

PSRouteMap routeMap = new PSRouteMap
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public override void Execute()
}
}

// this will thorw if hub does not exist.
// this will throw if hub does not exist.
IsParentVirtualHubPresent(this.ResourceGroupName, this.VirtualHubName);

ConfirmAction(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public override void Execute()
}
}

// this will thorw if hub does not exist.
// this will throw if hub does not exist.
IsParentVirtualHubPresent(this.ResourceGroupName, this.VirtualHubName);

if (this.RouteMapRule != null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public override void Execute()
this.ParentResourceName = parsedResourceId.ResourceName;
}

// this will thorw if hub does not exist.
// this will throw if hub does not exist.
IsParentVirtualHubPresent(this.ResourceGroupName, this.ParentResourceName);

PSRoutingIntent routingIntent = new PSRoutingIntent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public class RemoveAzureRmRoutingIntentCommand : RoutingIntentBaseCmdlet
[Parameter(
Mandatory = true,
ParameterSetName = CortexParameterSetNames.ByVirtualHubObject,
HelpMessage = "Name of therouting intent resource.")]
HelpMessage = "Name of the routing intent resource.")]
public string Name { get; set; }

[Alias("VirtualHub", "ParentVirtualHub")]
Expand Down Expand Up @@ -130,7 +130,7 @@ public override void Execute()
}
}

// this will thorw if hub does not exist.
// this will throw if hub does not exist.
IsParentVirtualHubPresent(this.ResourceGroupName, this.ParentResourceName);

ConfirmAction(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public override void Execute()
}
}

// this will thorw if hub does not exist.
// this will throw if hub does not exist.
IsParentVirtualHubPresent(this.ResourceGroupName, this.ParentResourceName);

if (this.RoutingPolicy != null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public override void Execute()
throw new PSArgumentException(string.Format(Properties.Resources.ChildResourceAlreadyPresentInResourceGroup, this.Name, this.ResourceGroupName, this.ParentResourceName));
}

// this will thorw if hub does not exist.
// this will throw if hub does not exist.
IsParentVirtualHubPresent(this.ResourceGroupName, this.ParentResourceName);

PSVHubRouteTable hubRouteTable = new PSVHubRouteTable();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ public override void Execute()
}
}

// this will thorw if hub does not exist.
// this will throw if hub does not exist.
IsParentVirtualHubPresent(this.ResourceGroupName, this.ParentResourceName);

ConfirmAction(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public override void Execute()
}
}

// this will thorw if hub does not exist.
// this will throw if hub does not exist.
IsParentVirtualHubPresent(this.ResourceGroupName, this.ParentResourceName);

if (this.Route != null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,17 +108,17 @@ public class GetAzureRmVirtualWanVpnServerConfigurationVpnProfileCommand : Virtu
Mandatory = true,
ValueFromPipelineByPropertyName = true,
ParameterSetName = CortexParameterSetNames.ByVirtualWanName + CortexParameterSetNames.ByVpnServerConfigurationResourceId,
HelpMessage = "The id of Vpn server configuraiton object this Virtual wan will be associated with.")]
HelpMessage = "The id of Vpn server configuration object this Virtual wan will be associated with.")]
[Parameter(
Mandatory = true,
ValueFromPipelineByPropertyName = true,
ParameterSetName = CortexParameterSetNames.ByVirtualWanObject + CortexParameterSetNames.ByVpnServerConfigurationResourceId,
HelpMessage = "The id of Vpn server configuraiton object this Virtual wan will be associated with.")]
HelpMessage = "The id of Vpn server configuration object this Virtual wan will be associated with.")]
[Parameter(
Mandatory = true,
ValueFromPipelineByPropertyName = true,
ParameterSetName = CortexParameterSetNames.ByVirtualWanResourceId + CortexParameterSetNames.ByVpnServerConfigurationResourceId,
HelpMessage = "The id of Vpn server configuraiton object this Virtual wan will be associated with.")]
HelpMessage = "The id of Vpn server configuration object this Virtual wan will be associated with.")]
[ResourceIdCompleter("Microsoft.Network/vpnServerConfigurations")]
public string VpnServerConfigurationId { get; set; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public override void Execute()
}
else
{
// Set IPv4 config even if no PeerAddresType has been specified for backward compatibility
// Set IPv4 config even if no PeerAddressType has been specified for backward compatibility
this.SetIpv4PeeringParameters(peering);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public void ConstructMicrosoftConfig(PSPeering peering)
}
else
{
// Set IPv4 config even if no PeerAddresType has been specified for backward compatibility
// Set IPv4 config even if no PeerAddressType has been specified for backward compatibility
peering.MicrosoftPeeringConfig = new PSPeeringConfig();
peering.MicrosoftPeeringConfig.AdvertisedPublicPrefixes = this.MicrosoftConfigAdvertisedPublicPrefixes?.ToList();
peering.MicrosoftPeeringConfig.CustomerASN = this.MicrosoftConfigCustomerAsn;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class AddAzureExpressRouteCircuitConnectionConfigCommand : AzureExpressRo
Position = 1,
Mandatory = true,
ValueFromPipeline = true,
HelpMessage = "Express Route Circuit Peering intiating connection")]
HelpMessage = "Express Route Circuit Peering initiating connection")]
[ValidateNotNullOrEmpty]
public PSExpressRouteCircuit ExpressRouteCircuit { get; set; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public class GetAzureExpressRouteCircuitConnectionConfigCommand : NetworkBaseCmd
Position = 1,
Mandatory = true,
ValueFromPipeline = true,
HelpMessage = "Express Route Circuit Peering intiating connection")]
HelpMessage = "Express Route Circuit Peering initiating connection")]
[ValidateNotNullOrEmpty]
public PSExpressRouteCircuit ExpressRouteCircuit { get; set; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class RemoveAzureExpressRouteCircuitConnectionConfigCommand : ExpressRout
Position = 1,
Mandatory = true,
ValueFromPipeline = true,
HelpMessage = "Express Route Circuit Peering intiating connection")]
HelpMessage = "Express Route Circuit Peering initiating connection")]
[ValidateNotNullOrEmpty]
public PSExpressRouteCircuit ExpressRouteCircuit { get; set; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public override void Execute()
}
else
{
// Set IPv4 config even if no PeerAddresType has been specified for backward compatibility
// Set IPv4 config even if no PeerAddressType has been specified for backward compatibility
this.SetIpv4PeeringParameters(peering);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public override void Execute()
}
else
{
// Set IPv4 config even if no PeerAddresType has been specified for backward compatibility
// Set IPv4 config even if no PeerAddressType has been specified for backward compatibility
this.SetIpv4PeeringParameters(peering);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public override void Execute()
}
else
{
// Set IPv4 config even if no PeerAddresType has been specified for backward compatibility
// Set IPv4 config even if no PeerAddressType has been specified for backward compatibility
this.SetIpv4PeeringParameters(peering);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public void ConstructMicrosoftConfig(PSExpressRouteCrossConnectionPeering peerin
}
else
{
// Set IPv4 config even if no PeerAddresType has been specified for backward compatibility
// Set IPv4 config even if no PeerAddressType has been specified for backward compatibility
peering.MicrosoftPeeringConfig = new PSPeeringConfig();
peering.MicrosoftPeeringConfig.AdvertisedPublicPrefixes = MicrosoftConfigAdvertisedPublicPrefix.ToList();
peering.MicrosoftPeeringConfig.CustomerASN = MicrosoftConfigCustomerAsn;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ static ProviderConfiguration()
RegisterConfiguration("Microsoft.FluidRelay/fluidRelayServers", "2025-03-10-preview", true, true, true);
}
/// <summary>
/// Register priavte endopoint connection and private link resource configuration
/// Register private endpoint connection and private link resource configuration
/// </summary>
/// <param name="type">Resource type</param>
/// <param name="apiVersion">Resource api version</param>
Expand Down
2 changes: 1 addition & 1 deletion src/Network/Network/Properties/Resources.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/Network/Network/Properties/Resources.resx
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@
<value>IP version is undefined</value>
</data>
<data name="TestConfiguration" xml:space="preserve">
<value>No test configuraiton is provided</value>
<value>No test configuration is provided</value>
</data>
<data name="TestGroupParameters" xml:space="preserve">
<value>Test group is missing one or more mandatory parameter</value>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public bool MultipleNetworkIdentifierExists(PSServiceEndpoint[] serviceEndpointC

private void RemoveExistingServiceWithoutIdentifier(PSSubnet subnet, PSServiceEndpoint item)
{
//delete any existing Service with the same name but without NetworkIdentier
//delete any existing Service with the same name but without NetworkIdentifier
var existingService = subnet.ServiceEndpoints.FirstOrDefault(s => s.Service == item.Service && s.NetworkIdentifier == null);
if (existingService != null)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public override void Execute()
var vnetVpnClientParametersModel = NetworkResourceManagerProfile.Mapper.Map<MNM.VpnClientParameters>(vpnClientParams);

//TODO:- This code is added just for current release of P2S feature as Generatevpnclientpackage API is broken & need to be fixed on server
//side as well as in overall Poweshell flow
//side as well as in overall Powershell flow
//string packageUrl = this.VirtualNetworkGatewayClient.Generatevpnclientpackage(ResourceGroupName, VirtualNetworkGatewayName, vnetVpnClientParametersModel);

string packageUrl = this.NetworkClient.Generatevpnclientpackage(ResourceGroupName, VirtualNetworkGatewayName, vnetVpnClientParametersModel);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public class InvokeAzureVirtualNetworkGatewayPrepareMigrationCommand : VirtualNe

[Parameter(
Mandatory = true,
HelpMessage = "Migration paramters to be passed to invoke prepare migration")]
HelpMessage = "Migration parameters to be passed to invoke prepare migration")]
[ValidateNotNullOrEmpty]
public PSVirtualNetworkGatewayMigrationParameters MigrationParameter { get; set; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ public class NewAzureVirtualNetworkGatewayCommand : VirtualNetworkGatewayBaseCmd
[Parameter(
Mandatory = false,
ValueFromPipelineByPropertyName = true,
HelpMessage = "P2S Client Connection Configuration that assiociate between address and policy group")]
HelpMessage = "P2S Client Connection Configuration that associate between address and policy group")]
public PSClientConnectionConfiguration[] ClientConnectionConfiguration { get; set; }

[Parameter(Mandatory = false, HelpMessage = "Run cmdlet in the background")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class NewAzureVpnClientConnectionConfigurationCommand : NetworkBaseCmdlet

[Parameter(
Mandatory = true,
HelpMessage = "The Associatted client address pool")]
HelpMessage = "The Associated client address pool")]
public string[] VpnClientAddressPool { get; set; }

[Parameter(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class ResizeAzureVirtualNetworkGatewayCommand : VirtualNetworkGatewayBase
[Parameter(
Mandatory = true,
ValueFromPipelineByPropertyName = true,
HelpMessage = "The gatway Sku:- Basic/Standard/HighPerformance/VpnGw1/VpnGw2/VpnGw3")]
HelpMessage = "The gateway Sku:- Basic/Standard/HighPerformance/VpnGw1/VpnGw2/VpnGw3")]
[ValidateSet(
MNM.VirtualNetworkGatewaySkuTier.Basic,
MNM.VirtualNetworkGatewaySkuTier.Standard,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ public class SetAzureVirtualNetworkGatewayCommand : VirtualNetworkGatewayBaseCmd
[Parameter(
Mandatory = false,
ValueFromPipelineByPropertyName = true,
HelpMessage = "P2S Client Connection Configuration that assiociate between address and policy group")]
HelpMessage = "P2S Client Connection Configuration that associate between address and policy group")]
public PSClientConnectionConfiguration[] ClientConnectionConfiguration { get; set; }

[Parameter(
Expand Down