Skip to content

Conversation

audunn
Copy link
Member

@audunn audunn commented Jun 28, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings June 28, 2025 20:28
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Bumps the NetAppFiles module to API version 2025-03-01, updating conversion helpers, documentation, and test session recordings to match the new spec.

  • Restores conversion logic and updates mappings in ModelExtensions for the new API version.
  • Adds an upcoming release note and updates the README to reference 2025-03-01.
  • Refreshes test session JSON files with new api-version, URIs, and related metadata.

Reviewed Changes

Copilot reviewed 6 out of 48 changed files in this pull request and generated no comments.

File Description
src/NetAppFiles/NetAppFiles/Helpers/ModelExtensions.cs Updated data protection conversion methods for 2025-03-01 (removed outdated assignments)
src/NetAppFiles/NetAppFiles/ChangeLog.md Added * Updated to api-version 2025-03-01 under Upcoming Release
src/NetAppFiles/NetAppFiles.Test/SessionRecords/*.json Refreshed scenario recordings with new API version, URIs, resource IDs, and timestamps
src/NetAppFiles/NetAppFiles.Management.Sdk/README.md Pointed input-file to the 2025-03-01 swagger commit
Comments suppressed due to low confidence (2)

src/NetAppFiles/NetAppFiles/Helpers/ModelExtensions.cs:293

  • The assignment for replication.EndpointType was removed, causing the EndpointType field to go unmapped. Please re-add this line to ensure the field is populated correctly.
                var replication = new ReplicationObject();                                

src/NetAppFiles/NetAppFiles/Helpers/ModelExtensions.cs:326

  • The EndpointType assignment is also removed in the ConvertDataProtectionFromPs_2022_11_01 method; restoring it will maintain consistent mapping across versions.
                // replication.ReplicationId = psDataProtection.Replication.ReplicationId;                

@YanaXu
Copy link
Contributor

YanaXu commented Jun 30, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@YanaXu YanaXu merged commit 0f31606 into Azure:main Jul 1, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants