Skip to content

Conversation

vidai-msft
Copy link
Contributor

@vidai-msft vidai-msft commented Jun 27, 2025

Description

This PR accomplishes the followings.

  • Windows-2019 agent has been deprecated. Remove all windows-2019 jobs and replace windows-2022 jobs with windows-latest.
  • Fix the MacOS hang issue when running live test.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings June 27, 2025 08:52
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated Windows-2019 jobs and updates the live test pipelines to use newer platforms while introducing a new script to clean up Azure Identity Keys on MacOS to address a hanging issue.

  • Replaces Windows-2019 jobs with windows-latest in pipeline definitions
  • Updates job names and target operating systems (including shifts to Linux and MacOS for some tasks)
  • Introduces a Bash script to clean MacOS keychain entries

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tools/TestFx/Live/CleanAzureIdentityKeysForMacOS New Bash script added for cleaning keychain entries on MacOS
.azure-pipelines/util/live-test-steps.yml Added a new Bash task to invoke the cleanup script on MacOS
.azure-pipelines/live-test.yml Updated pipeline definitions: replacing deprecated Windows agents and renaming jobs; some jobs now target Linux and MacOS
Comments suppressed due to low confidence (3)

.azure-pipelines/live-test.yml:78

  • The job 'ps_7_4_x_linux' now targets a Linux agent instead of Windows; please confirm that this change in platform is intentional.
      name: 'ps_7_4_x_linux'

.azure-pipelines/live-test.yml:88

  • The job 'ps_7_5_x_linux' has been shifted from Windows to Linux; please verify if this platform change aligns with the intended live test environment.
      name: 'ps_7_5_x_linux'

.azure-pipelines/live-test.yml:98

  • The job 'ps_latest_linux' now runs on a Linux agent instead of the previous Windows configuration; please double-check that this alteration is expected.
      name: 'ps_latest_linux'

galleryName: ${{ parameters.GalleryName }}
pipelineBuildId: ${{ parameters.PipelineBuildId }}

- template: util/live-test-steps.yml
Copy link

Copilot AI Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] There are multiple commented-out pipeline template invocations; consider removing these unused code blocks to improve maintainability.

Copilot uses AI. Check for mistakes.

@YanaXu YanaXu enabled auto-merge (squash) June 27, 2025 09:34
@YanaXu YanaXu merged commit b776eb8 into main Jun 27, 2025
12 checks passed
@vidai-msft vidai-msft deleted the vidai/livetest branch July 18, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants