Trusted Launch for VM/VMSS #27260
Merged
Trusted Launch for VM/VMSS #27260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grizzlytheodore
requested review from
Sandido,
bilaakpan-ms and
haagha
as code owners
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Sandido
suggested changes
Mar 7, 2025
src/Compute/Compute/Strategies/ComputeRp/VirtualMachineScaleSetStrategy.cs
Show resolved
Hide resolved
Sandido
reviewed
Mar 19, 2025
| Start-AzVmss -ResourceGroupName $rgname -Name $vmssName2 | ||
| $updated_vmss = Get-AzVmss -ResourceGroupName $rgname -Name $vmssName2; | ||
|
|
||
| Assert-Null $updated_vmss.VirtualMAchineProfile.SecurityProfile.SecurityType; |
There was a problem hiding this comment.
nitpick, A shouldnt be capitalized.
| # Setup | ||
| $rgname = Get-ComputeTestResourceName; | ||
| $loc = Get-ComputeVMLocation; | ||
| $loc = "westus2"; |
There was a problem hiding this comment.
future improvement, is there an API to call to see if there is availability in a region then select that region? I think the sku vm list api can do this.
Sandido
approved these changes
Mar 19, 2025
|
can you review/merge @notyashhh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
addressing: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1477
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.