[Compute] GalleryImageVersion Powershell commands to support BlockDeletionBeforeEndOfLife parameter #27224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haagha
requested review from
Sandido,
bilaakpan-ms and
grizzlytheodore
as code owners
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
@NoriZC here is the new PR |
|
Hi @haagha if you want to include this PR in final RC of current release, please:
|
6 tasks
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
notyashhh
approved these changes
Mar 25, 2025
notyashhh
requested changes
Mar 25, 2025
| Mandatory = false, | ||
| ValueFromPipelineByPropertyName = true, | ||
| HelpMessage = "This boolean will be passed by the customers to enable their GalleryImageVersion resources from accidental deletions. If this boolean is set to true, the image deletions will be blocked before its EndOfLife date.")] | ||
| public bool? BlockDeletionBeforeEndOfLife { get; set; } |
There was a problem hiding this comment.
for create method, this parameter should be SwitchParameter, no?
There was a problem hiding this comment.
updating this to switch does not require re-recording the test
grizzlytheodore
previously approved these changes
Mar 25, 2025
notyashhh
dismissed
grizzlytheodore’s stale review
The base branch was changed.
notyashhh
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1473
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.