[Az.Dns] Add NAPTR support and tests #26239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzDnsDnssecConfig | Get-AzDnsDnssecConfig Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDnsDnssecConfig | Get-AzDnsDnssecConfig changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzDnsDnssecConfig | Get-AzDnsDnssecConfig Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDnsDnssecConfig | Get-AzDnsDnssecConfig changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
WhiteHorseV
changed the title
|
I will update the test runs after the NAPTR feature is enabled in the PPE/Prod region. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @WhiteHorseV , you need to add the suppress for the cmdlets to avoid ci checking |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
Hi @Nickcandy, I have updated the PR with test recordings. Can you please help review the PR? |
djr-jsr
suggested changes
Oct 31, 2024
djr-jsr
suggested changes
Oct 31, 2024
Nickcandy
reviewed
Oct 31, 2024
|
LGTM |
djr-jsr
approved these changes
Oct 31, 2024
Nickcandy
approved these changes
Oct 31, 2024
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Nickcandy
approved these changes
Oct 31, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Add NAPTR support and tests * Updated the test results * Update recordings and merge main * Update changelog and help sections for NAPTR record type * Updating signatures in staticanalysis exceptions and typo fixes in samples * Updated the typo in doc and updated the sdk version to 1.2.2 * Fix the changelog as per the documentation * Remove empty line --------- Co-authored-by: Sandeep Kadagathur Vadiraj <[email protected]>
VeryEarly
added a commit
that referenced
this pull request
Nov 4, 2024
* Add NAPTR support and tests * Updated the test results * Update recordings and merge main * Update changelog and help sections for NAPTR record type * Updating signatures in staticanalysis exceptions and typo fixes in samples * Updated the typo in doc and updated the sdk version to 1.2.2 * Fix the changelog as per the documentation * Remove empty line --------- Co-authored-by: WhiteHorseV <[email protected]> Co-authored-by: Sandeep Kadagathur Vadiraj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.