Skip to content

Conversation

yuc-Li
Copy link
Contributor

@yuc-Li yuc-Li commented Sep 19, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Sep 19, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.HDInsight
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Add-AzHDInsightClusterIdentity 1 27 Mismatched_Parameter_Value_Type Add-AzHDInsightClusterIdentity -AadTenantId $tenantId is not an expected parameter value type. -AadTenantId Use correct parameter value type. Expected Type is guid. Now the type is .(Command).
⚠️ Add-AzHDInsightClusterIdentity 1 42 Unassigned_Variable New-AzHDInsightCluster -StorageContainer $storageAccountContainer is a null-valued parameter value. -StorageContainer Assign value for $storageAccountContainer.
⚠️ Add-AzHDInsightComponentVersion 1 36 Unassigned_Variable New-AzHDInsightCluster -SshCredential $sshCredentials is a null-valued parameter value. -SshCredential Assign value for $sshCredentials.
⚠️ Add-AzHDInsightConfigValue 1 37 Unassigned_Variable New-AzHDInsightCluster -StorageContainer $storageAccountContainer is a null-valued parameter value. -StorageContainer Assign value for $storageAccountContainer.
⚠️ Add-AzHDInsightStorage 1 30 Unassigned_Variable Add-AzHDInsightStorage -StorageAccountKey $key2 is a null-valued parameter value. -StorageAccountKey Assign value for $key2.
⚠️ New-AzHDInsightCluster 9 47 Mismatched_Parameter_Value_Type New-AzHDInsightCluster -SecurityProfile $config.SecurityProfile is not an expected parameter value type. -SecurityProfile Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.HDInsight.Models.AzureHDInsightSecurityProfile. Now the type is .(Command).
⚠️ New-AzHDInsightCluster 11 27 Unassigned_Variable New-AzHDInsightIPConfiguration -SubnetId $subnetId is a null-valued parameter value. -SubnetId Assign value for $subnetId.
⚠️ New-AzHDInsightCluster 13 42 Mismatched_Parameter_Value_Type New-AzHDInsightCluster -SecurityProfile $config.SecurityProfile is not an expected parameter value type. -SecurityProfile Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.HDInsight.Models.AzureHDInsightSecurityProfile. Now the type is .(Command).
⚠️ New-AzHDInsightClusterConfig 1 23 Unassigned_Variable Add-AzHDInsightStorage -StorageAccountKey $key2 is a null-valued parameter value. -StorageAccountKey Assign value for $key2.
⚠️ New-AzHDInsightMapReduceJobDefinition 1 5 Unassigned_Variable New-AzHDInsightMapReduceJobDefinition -StatusFolder $statusFolder is a null-valued parameter value. -StatusFolder Assign value for $statusFolder.
⚠️ New-AzHDInsightMapReduceJobDefinition 1 6 Unassigned_Variable New-AzHDInsightMapReduceJobDefinition -ClassName $className is a null-valued parameter value. -ClassName Assign value for $className.
⚠️ New-AzHDInsightMapReduceJobDefinition 1 7 Unassigned_Variable New-AzHDInsightMapReduceJobDefinition -JarFile $jarFilePath is a null-valued parameter value. -JarFile Assign value for $jarFilePath.
⚠️ New-AzHDInsightSqoopJobDefinition 1 5 Unassigned_Variable New-AzHDInsightSqoopJobDefinition -StatusFolder $statusFolder is a null-valued parameter value. -StatusFolder Assign value for $statusFolder.
⚠️ New-AzHDInsightSqoopJobDefinition 1 6 Unassigned_Variable New-AzHDInsightSqoopJobDefinition -Command $sqoopCommand is a null-valued parameter value. -Command Assign value for $sqoopCommand.
⚠️ Set-AzHDInsightDefaultStorage 1 23 Unassigned_Variable Set-AzHDInsightDefaultStorage -StorageAccountKey $key2 is a null-valued parameter value. -StorageAccountKey Assign value for $key2.
⚠️ Set-AzHDInsightGatewayCredential 2 3 Unassigned_Variable Set-AzHDInsightGatewayCredential -HttpCredential $clusterCreds is a null-valued parameter value. -HttpCredential Assign value for $clusterCreds.
⚠️ Stop-AzHDInsightJob 1 7 Unassigned_Variable Stop-AzHDInsightJob -JobId $jobId is a null-valued parameter value. -JobId Assign value for $jobId.
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Add-AzHDInsightClusterIdentity 1 27 Mismatched_Parameter_Value_Type Add-AzHDInsightClusterIdentity -AadTenantId $tenantId is not an expected parameter value type. -AadTenantId Use correct parameter value type. Expected Type is guid. Now the type is .(Command).
⚠️ Add-AzHDInsightClusterIdentity 1 42 Unassigned_Variable New-AzHDInsightCluster -StorageContainer $storageAccountContainer is a null-valued parameter value. -StorageContainer Assign value for $storageAccountContainer.
⚠️ Add-AzHDInsightComponentVersion 1 36 Unassigned_Variable New-AzHDInsightCluster -SshCredential $sshCredentials is a null-valued parameter value. -SshCredential Assign value for $sshCredentials.
⚠️ Add-AzHDInsightConfigValue 1 37 Unassigned_Variable New-AzHDInsightCluster -StorageContainer $storageAccountContainer is a null-valued parameter value. -StorageContainer Assign value for $storageAccountContainer.
⚠️ Add-AzHDInsightStorage 1 30 Unassigned_Variable Add-AzHDInsightStorage -StorageAccountKey $key2 is a null-valued parameter value. -StorageAccountKey Assign value for $key2.
⚠️ New-AzHDInsightCluster 9 47 Mismatched_Parameter_Value_Type New-AzHDInsightCluster -SecurityProfile $config.SecurityProfile is not an expected parameter value type. -SecurityProfile Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.HDInsight.Models.AzureHDInsightSecurityProfile. Now the type is .(Command).
⚠️ New-AzHDInsightCluster 11 27 Unassigned_Variable New-AzHDInsightIPConfiguration -SubnetId $subnetId is a null-valued parameter value. -SubnetId Assign value for $subnetId.
⚠️ New-AzHDInsightCluster 13 42 Mismatched_Parameter_Value_Type New-AzHDInsightCluster -SecurityProfile $config.SecurityProfile is not an expected parameter value type. -SecurityProfile Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.HDInsight.Models.AzureHDInsightSecurityProfile. Now the type is .(Command).
⚠️ New-AzHDInsightClusterConfig 1 23 Unassigned_Variable Add-AzHDInsightStorage -StorageAccountKey $key2 is a null-valued parameter value. -StorageAccountKey Assign value for $key2.
⚠️ New-AzHDInsightMapReduceJobDefinition 1 5 Unassigned_Variable New-AzHDInsightMapReduceJobDefinition -StatusFolder $statusFolder is a null-valued parameter value. -StatusFolder Assign value for $statusFolder.
⚠️ New-AzHDInsightMapReduceJobDefinition 1 6 Unassigned_Variable New-AzHDInsightMapReduceJobDefinition -ClassName $className is a null-valued parameter value. -ClassName Assign value for $className.
⚠️ New-AzHDInsightMapReduceJobDefinition 1 7 Unassigned_Variable New-AzHDInsightMapReduceJobDefinition -JarFile $jarFilePath is a null-valued parameter value. -JarFile Assign value for $jarFilePath.
⚠️ New-AzHDInsightSqoopJobDefinition 1 5 Unassigned_Variable New-AzHDInsightSqoopJobDefinition -StatusFolder $statusFolder is a null-valued parameter value. -StatusFolder Assign value for $statusFolder.
⚠️ New-AzHDInsightSqoopJobDefinition 1 6 Unassigned_Variable New-AzHDInsightSqoopJobDefinition -Command $sqoopCommand is a null-valued parameter value. -Command Assign value for $sqoopCommand.
⚠️ Set-AzHDInsightDefaultStorage 1 23 Unassigned_Variable Set-AzHDInsightDefaultStorage -StorageAccountKey $key2 is a null-valued parameter value. -StorageAccountKey Assign value for $key2.
⚠️ Set-AzHDInsightGatewayCredential 2 3 Unassigned_Variable Set-AzHDInsightGatewayCredential -HttpCredential $clusterCreds is a null-valued parameter value. -HttpCredential Assign value for $clusterCreds.
⚠️ Stop-AzHDInsightJob 1 7 Unassigned_Variable Stop-AzHDInsightJob -JobId $jobId is a null-valued parameter value. -JobId Assign value for $jobId.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 40.38 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 40.38% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 40.38% Test coverage for the module cannot be lower than 50%.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 40.38% Test coverage for the module cannot be lower than 50%.
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@yuc-Li yuc-Li removed this from the Az 12.4.0 (October 2024, 2024-10-08) milestone Sep 20, 2024
@yuc-Li yuc-Li marked this pull request as ready for review October 31, 2024 03:58
Copy link
Contributor

@vidai-msft vidai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vidai-msft
Copy link
Contributor

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@vidai-msft vidai-msft merged commit 02eeee0 into Azure:main Nov 1, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 1, 2024
* Regenerate

* Update help doc

* Update test

* fix a bug and add a param -Tag

* Update test

* Update help doc

* Update changelog.

* Update changelog

* update example

* Update changelog

* Update a example error

* Remove some change

* Update test

* SignatureIssue

* Update SignatureIssue

* Update

* Update

* Update

---------

Co-authored-by: v-yuchenli <[email protected]>
VeryEarly added a commit that referenced this pull request Nov 4, 2024
* Regenerate

* Update help doc

* Update test

* fix a bug and add a param -Tag

* Update test

* Update help doc

* Update changelog.

* Update changelog

* update example

* Update changelog

* Update a example error

* Remove some change

* Update test

* SignatureIssue

* Update SignatureIssue

* Update

* Update

* Update

---------

Co-authored-by: yuc-Li <[email protected]>
Co-authored-by: v-yuchenli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants