Skip to content

Conversation

AgarwalVivek
Copy link
Contributor

@AgarwalVivek AgarwalVivek commented Feb 21, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Feb 21, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.CosmosDB
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.CosmosDB. Add a changelog record under Upcoming Release section with past tense.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.CosmosDB. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@AgarwalVivek
Copy link
Contributor Author

@dolauli I see you helped with the merge of https://github.com/Azure/azure-powershell/pull/23666/files/8fbbeb8ba4eb39c87e795a28c3e0687494253ba8#diff-9957bb3df372fd6fc76050b6f6a9b4cadff4b3712f9b617e387962914b6d4952

There is a bug that we are trying to fix in immediate next release :2024-03-05 and this change is crucial to go in.

I am trying to get some reviews. Can you help. Thanks in advance!

@msJinLei
Copy link
Contributor

@AgarwalVivek Please fix the failed test cases. Please add the test to cover your changes.

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@AgarwalVivek
Copy link
Contributor Author

@AgarwalVivek Please fix the failed test cases. Please add the test to cover your changes.

Thanks for taking a look. @msJinLei Can you please point me to the location where i can access the logs from pipeline:
https://dev.azure.com/azclitools/public/_build/results?buildId=132460&view=logs&j=b17395f6-68a3-5682-0476-d3f6f1043109&t=67f633ab-4360-5839-af42-f446e0c847f0&l=35259

@AgarwalVivek
Copy link
Contributor Author

AgarwalVivek commented Feb 23, 2024

@AgarwalVivek Please fix the failed test cases. Please add the test to cover your changes.

Hi @msJinLei can you please share the preview branch details for this bug fix change? previously when the bug was introduced we used Az.CosmosDB-preview branch. Can we use the same branch this time?

cc: @amisi01

@msJinLei
Copy link
Contributor

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@AgarwalVivek
Copy link
Contributor Author

/azp run azure-powershell - security-tools

@msJinLei what about it ? please suggest.

@msJinLei msJinLei closed this Feb 26, 2024
@msJinLei msJinLei reopened this Feb 26, 2024
@VeryEarly
Copy link
Collaborator

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@msJinLei msJinLei merged commit 184bdc7 into Azure:main Feb 26, 2024
msJinLei added a commit that referenced this pull request Feb 27, 2024
* changelog.md for ntbr issue

* Update ChangeLog.md

* Update ChangeLog.md

---------

Co-authored-by: Jin Lei <[email protected]>
AgarwalVivek added a commit to AgarwalVivek/azure-powershell that referenced this pull request Feb 27, 2024
@AgarwalVivek
Copy link
Contributor Author

AgarwalVivek commented Feb 27, 2024

@msJinLei can you please share the azure-powershell version that customer would see this fix in?

wyunchi-ms pushed a commit that referenced this pull request Feb 28, 2024
* cherry-pick stable change into preview; stable:#24199

* 1 out of 7 fixed

* fixing other 2 tests

* fixing remaining 4 tests failure due to session record
@msJinLei
Copy link
Contributor

msJinLei commented Mar 6, 2024

@msJinLei can you please share the azure-powershell version that customer would see this fix in?

@AgarwalVivek Az.CosmosDB 1.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants