[CosmosDB] GA PowerShell commands for InAccount Restore of Deleted Database/ Containers feature for SQL/Mongo/Table/Gremlin #23666

ddhamotharan · 2023-12-05T12:00:22Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell
- General release
- Public preview
- Private preview
- Engineering build
- N/A
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- For autorest-based development mode, include the changelog in the PR description.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2023-12-05T12:00:26Z

️✔️Az.Accounts

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Az.CosmosDB

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Breaking Change Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Signature Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Help Example Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Help File Existence Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️File Change Check

⚠️PowerShell Core - Windows

Type Cmdlet Description Remediation

⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.

⚠️Windows PowerShell - Windows

Type Cmdlet Description Remediation

⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.

️✔️UX Metadata Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Generated Sdk Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️PowerShell Core - Linux

️✔️PowerShell Core - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.KeyVault

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Network

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Resources

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

dolauli · 2023-12-14T01:47:34Z

@ddhamotharan Please fix the CI failures.

…n record

ddhamotharan · 2023-12-17T01:14:19Z

@dolauli Fixed all CI failures. Please review when you get a chance. thank you

dolauli

LGTM

amisi01 · 2023-12-20T22:38:13Z

src/CosmosDB/CosmosDB/Gremlin/RestoreAzCosmosDBGremlinDatabase.cs

+                    return;
+                }
+
+                Regex regex = new Regex(@"[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}");


DatabaseAccountInstanceId?

similar to other files as well?

amisi01 · 2023-12-20T22:38:43Z

src/CosmosDB/CosmosDB/Gremlin/RestoreAzCosmosDBGremlinDatabase.cs

+                    }
+                }
+
+                utcRestoreDateTime = latestDeleteTime.AddSeconds(-2);


similar in other files as well?

amisi01 · 2023-12-20T22:48:43Z

src/CosmosDB/CosmosDB/Gremlin/RestoreAzCosmosDBGremlinGraph.cs

+                    accountInstanceId,
+                    databaseRid,
+                    latestDatabaseCreateOrRecreateTime.ToString(),
+                    (latestDatabaseCreateOrRecreateTime < latestDatabaseDeleteTime) ? latestDatabaseDeleteTime.ToString() : DateTime.MaxValue.ToString()).GetAwaiter().GetResult().Body;


DateTime.MaxValue as restore time won't work, right?
can we simplify logic as following:
for snapshot : snapshots.sorted():
if snapshot.type == "Delete": latestDeleteSnapshot = snapshot
else if snapshot.type == "(Re)Create": latestDeleteSnapshot = null

latestDeleteSnapshot == null : not restorable

* apply Az.CosmosDB-preview branch CosmosDB folder to this branch * Use autorest.powershell to generate management SDK for cosmosDB (#22413) * remove the custom code since character case change is not treated as a breaking change (#22500) * regen sdk * specify header type as string to fix build error * update autorest file to align with main; regen sdk * fix casing * [Cosmos DB] Powershell changes for 2023-03-15 stable API (#21990) * added tests for listconnectionstrings; updated changelog * add changes for list connection strings response * re-record test * update changelog * Add location api changes * Added test recording for location api * re-record tests * re-record tests * Revert "add changes for list connection strings response" This reverts commit ff3ef0a. * update changelog, update and re-record account tests --------- Co-authored-by: Udit Singh <[email protected]> * CosmosDB - New Restore Parameter (#22585) * restore new param public network access * minor fixes * test change * stable changes 1 * md param def changed * reverting test changes for build * restore ts * test and test recording * CosmosDB 2023-09-15 release (#22726) (#22953) * genrated changes * help and changelog and test case update * Powershell model changes for burst capacity * added customer managed key status to PSDatabaseAccountGetResults.cs * added recording for MongoOperationsTests and SqlOperationsTest * added recording for remaining tests * rerecorded failed tests * added changes in tests * Minimal Tls version for create and update * fixed build errors * updated tls version in test * updated commit id * MinimalTlsVersion to changelog * Update ChangeLog.md Added CustomerManagedKeyStatus to the Changelog * mask 'primaryReadOnlyMasterKey' and 'secondaryReadOnlyMasterKey' in recorded test * mask 'primaryMasterKey' and 'secondaryMasterKey' in recorded test * rerecorded account tests * rerecorded account tests * rerecorded Cassandra tests * re-recorded all but mongo and restore tests --------- Co-authored-by: Richa Sharma <[email protected]> Co-authored-by: Adrián Sibaja Retana <[email protected]> Co-authored-by: unknown <[email protected]> Co-authored-by: AdrianSibajaRetana <[email protected]> * [CosmosDB] GA PowerShell commands for InAccount Restore of Deleted Database/ Containers feature for SQL/Mongo/Table/Gremlin (#23666) * changes and generated code * update tests * update session records * update help files * update changelog * update session records * update TestUpdateCosmosDBAccountBackupPolicyToContinuous30Days session record * update session records * add notimestamp tests and update few old session records * regen sdk, fix build error * fix duplicate code * nit fix restore tests * re-record tests * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account (#21736) * Merge branch 'Az.CosmosDB-preview' of https://github.com/SrinikhilReddy/azure-powershell into features/users/nanarava/enablepmerge * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * Update src/CosmosDB/CosmosDB/ChangeLog.md Co-authored-by: Jin Lei <[email protected]> * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * Update ChangeLog.md Remove duplicate line * Resolve code comments. --------- Co-authored-by: Jin Lei <[email protected]> * Replace Start-Sleep with Start-TestSleep for all test cases (#23780) * re-record account test * fix typo * [Cosmos DB] Powershell changes for 2023-04-15 stable API (Continuous 7 GA) (#21685) * move to new swagger version and prereq * edit readme.md * manually generated from autorest * Continuous 7 days change * add 2 new test recordings * fix example issues * add all test recordings for RestoreTests suite * fix New-AzCosmosDBAccount.md * add almost all test recordings * add 4 more successful recordings. all working now * no examples * clean up help file * add output type to cmdlet * suppress errors for existing cmdlets * Revert "suppress errors for existing cmdlets" This reverts commit f36e275. * suppress static validation errors for existing commands --------- Co-authored-by: Xiaogang <[email protected]> Co-authored-by: Udit Singh <[email protected]> Co-authored-by: mayankkatwal <[email protected]> Co-authored-by: Yabo Hu <[email protected]> Co-authored-by: Richa Sharma <[email protected]> Co-authored-by: Adrián Sibaja Retana <[email protected]> Co-authored-by: unknown <[email protected]> Co-authored-by: AdrianSibajaRetana <[email protected]> Co-authored-by: ddhamotharan <[email protected]> Co-authored-by: Srinikhil Naravamakula <[email protected]> Co-authored-by: Jin Lei <[email protected]> Co-authored-by: Vincent Dai <[email protected]> Co-authored-by: vinhms <[email protected]>

ddhamotharan added 3 commits December 12, 2023 23:11

changes and generated code

42d01a9

update tests

d5393f3

update session records

6ff5692

ddhamotharan force-pushed the users/ddhamotharan/2023-11-15 branch from f37c985 to 6ff5692 Compare December 13, 2023 07:19

ddhamotharan marked this pull request as ready for review December 13, 2023 07:28

dolauli self-assigned this Dec 13, 2023

ddhamotharan added 2 commits December 13, 2023 13:01

update help files

c5312cd

update changelog

a691acb

ddhamotharan added 4 commits December 13, 2023 18:35

update session records

431c44e

update TestUpdateCosmosDBAccountBackupPolicyToContinuous30Days sessio…

3dd3805

…n record

update session records

af8528c

add notimestamp tests and update few old session records

8fbbeb8

dolauli approved these changes Dec 18, 2023

View reviewed changes

dolauli merged commit 22fe166 into Azure:main Dec 18, 2023

ddhamotharan added this to the Az 11.2.0 (January 2024, 2024-01-02) milestone Dec 20, 2023

amisi01 reviewed Dec 20, 2023

View reviewed changes

ddhamotharan mentioned this pull request Dec 21, 2023

[CosmosDB] Fixes for GA PowerShell commands for InAccount Restore of Deleted Database/ Containers feature for SQL/Mongo/Table/Gremlin #23802

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CosmosDB] GA PowerShell commands for InAccount Restore of Deleted Database/ Containers feature for SQL/Mongo/Table/Gremlin #23666

[CosmosDB] GA PowerShell commands for InAccount Restore of Deleted Database/ Containers feature for SQL/Mongo/Table/Gremlin #23666

Uh oh!

ddhamotharan commented Dec 5, 2023 •

edited

Loading

Uh oh!

azure-client-tools-bot-prd bot commented Dec 5, 2023 •

edited

Loading

Uh oh!

dolauli commented Dec 14, 2023

Uh oh!

ddhamotharan commented Dec 17, 2023

Uh oh!

dolauli left a comment

Uh oh!

amisi01 Dec 20, 2023

Uh oh!

amisi01 Dec 20, 2023

Uh oh!

amisi01 Dec 20, 2023

Uh oh!

amisi01 Dec 20, 2023

Uh oh!

amisi01 Dec 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[CosmosDB] GA PowerShell commands for InAccount Restore of Deleted Database/ Containers feature for SQL/Mongo/Table/Gremlin #23666

[CosmosDB] GA PowerShell commands for InAccount Restore of Deleted Database/ Containers feature for SQL/Mongo/Table/Gremlin #23666

Uh oh!

Conversation

ddhamotharan commented Dec 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Dec 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dolauli commented Dec 14, 2023

Uh oh!

ddhamotharan commented Dec 17, 2023

Uh oh!

dolauli left a comment

Choose a reason for hiding this comment

Uh oh!

amisi01 Dec 20, 2023

Choose a reason for hiding this comment

Uh oh!

amisi01 Dec 20, 2023

Choose a reason for hiding this comment

Uh oh!

amisi01 Dec 20, 2023

Choose a reason for hiding this comment

Uh oh!

amisi01 Dec 20, 2023

Choose a reason for hiding this comment

Uh oh!

amisi01 Dec 20, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ddhamotharan commented Dec 5, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Dec 5, 2023 •

edited

Loading