-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Az.Cosmos DB Preview - New Restore Parameter #21464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wyunchi-ms
merged 4 commits into
Azure:Az.CosmosDB-preview
from
mayankkatwal:Az.CosmosDB-preview
Apr 10, 2023
Merged
Az.Cosmos DB Preview - New Restore Parameter #21464
wyunchi-ms
merged 4 commits into
Azure:Az.CosmosDB-preview
from
mayankkatwal:Az.CosmosDB-preview
Apr 10, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.CosmosDB
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
️✔️Az.Resources
️✔️Az.Sql
️✔️Az.Storage
|
Thank you for your contribution mayankkatwal! We will review the pull request and get back to you soon. |
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
wyunchi-ms
reviewed
Apr 7, 2023
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
wyunchi-ms
approved these changes
Apr 10, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a very small change to allow users to pass in a flag (PublicNetworkAccess) to the restore powershell command. This flag will get propagated to the restore workflow and will restore the database account with either public network access as enabled or disabled. This new parameter has existed for some time as the provision database account ps command leverages the same. Therefore, no changes to any sdk is needed, thus making this a minor change.
Right now we are trying to get this change merged in a preview branch so that we can create a module off of it and allow some customers to use the change
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.