AzureCP PR - Fix Extension ID Issue #387 #1792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HPF PR: dev <- Azure:dev
HPF PR: dev <- Azure:dev
HPF PR: dev <- Azure:dev
HPF PR: dev <- Azure:dev
HPF PR: dev <- Azure:dev
HPF PR: dev <- Azure:dev
HPF PR: dev <- Azure:dev
HPF PR: dev <- Azure:dev
HPF PR: dev <- Azure:dev
HPF PR: dev <- Azure:dev
Adding RunnerTests.cs to run runner tests using Access Token
HPF PR: dev <- Azure:dev
HPF PR: dev <- Azure:dev
# Conflicts: # setup/azurecmdfiles.wxi
HPF PR: dev <- Azure:dev
|
@hyonholee @hovsepm Please help review. |
| } | ||
|
|
||
| return roleName; | ||
| } |
There was a problem hiding this comment.
this method seems too complex for the thing it is doing.
Just put following on line 37 and you should be good:
return disallowedCharactersRegex.Replace(roleName,"");
HPF PR: dev <- Azure:dev
Remove tests from RunnerTests.csv to reduce run time
HPF PR: dev <- Azure:dev
HPF PR: dev <- Azure:dev
|
Ping... @hovsepm |
HPF PR: dev <- Azure:dev
|
@huangpf please fix merge conflicts, pull the latest, and re-generate the wix file. |
# Conflicts: # setup/azurecmdfiles.wxi
|
@markcowl Done~ |
markcowl
added a commit
that referenced
this pull request
Feb 17, 2016
AzureCP PR - Fix Extension ID Issue #387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AzureCP PR - Fix Extension ID Issue #387